Bug 34091 - Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module
Summary: Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-06-22 09:10 UTC by Katrin Fischer
Modified: 2023-12-14 21:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01,23.05.07


Attachments
Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl (1.29 KB, patch)
2023-12-01 17:57 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl (1.34 KB, patch)
2023-12-01 19:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl (1.39 KB, patch)
2023-12-07 20:03 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-06-22 09:10:06 UTC
Found testing in 22.11, but I believe also present in current versions. The help reads:

--log-modules      Specify which action log modules to trim. Repeatable.

But the parameter is actually --log-module
Comment 1 Fridolin Somers 2023-12-01 17:57:48 UTC
Created attachment 159471 [details] [review]
Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl

This parameter is actually --log-module.

Test plan :
Run misc/cronjobs/cleanup_database.pl -h
Confirm you see --log-module
Comment 2 David Nind 2023-12-01 19:25:29 UTC
Created attachment 159480 [details] [review]
Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl

This parameter is actually --log-module.

Test plan :
Run misc/cronjobs/cleanup_database.pl -h
Confirm you see --log-module

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-12-07 20:03:33 UTC
Created attachment 159664 [details] [review]
Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl

This parameter is actually --log-module.

Test plan :
Run misc/cronjobs/cleanup_database.pl -h
Confirm you see --log-module

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-07 20:04:30 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Katrin Fischer 2023-12-11 18:46:42 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2023-12-12 07:48:17 UTC
Pushed to 23.11.x for 23.11.01
Comment 7 Lucas Gass 2023-12-14 21:24:49 UTC
Backported to 23.05.x for upcoming 23.05.07