Bug 34095 - Shipping cost should default to a blank box instead of 0.00
Summary: Shipping cost should default to a blank box instead of 0.00
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Laura Escamilla
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-22 12:54 UTC by Laura Escamilla
Modified: 2024-12-23 08:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10
Circulation function:


Attachments
Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank. (1.34 KB, patch)
2023-08-11 15:39 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank. (1.49 KB, patch)
2023-08-17 08:39 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank. (1.55 KB, patch)
2023-08-24 22:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2023-06-22 12:54:45 UTC
Shipment cost should default to a blank box instead of 0.00.
Comment 1 Laura Escamilla 2023-08-11 15:39:17 UTC
Created attachment 154377 [details] [review]
Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank.

To test:
1. Create a new basket (Orders are not standing, and items are created when placing an order)
2. Add a record to the basket. 
3. Close the basket. 
4. Receive the shipment - when creating the invoice leave the shipment cost as blank and then receive the item you added to the basket.  
5. View the invoice and notice that the Shipping Cost is showing as “0.00” 
6. Apply the patch and restart_all
7. Repeat steps 1-5
8. View the invoice and notice that the Shipping Cost is now blank. 
9. Repeat steps 1-5 but this time add a shipment cost when creating the invoice. When you view the invoice confirm that the shipping cost does show up. 
10. Sign off.
Comment 2 Biblibre Sandboxes 2023-08-17 08:39:33 UTC
Created attachment 154499 [details] [review]
Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank.

Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Comment 3 Katrin Fischer 2023-08-24 22:36:55 UTC
Created attachment 154764 [details] [review]
Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank.

Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-08-30 13:06:33 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-30 20:16:20 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-08-31 10:47:01 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x