Bug 34103 - Capitalization: Currencies & Exchange rates
Summary: Capitalization: Currencies & Exchange rates
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Caroline Cyr La Rose
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-22 20:05 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:46 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:

Attachments
Bug 34103: Capitalization: Currencies & Exchange rates (2.12 KB, patch)
2023-06-22 20:10 UTC, Caroline Cyr La Rose 		Details | Diff | Splinter Review
Bug 34103: Capitalization: Currencies & Exchange rates (2.18 KB, patch)
2023-06-22 20:24 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-06-22 20:05:02 UTC 
When going to Administration > Currencies and exchange rates, the breadcrumb still has the old way of capitalizing (and the ampersand).

Administration > Currencies & Exchange rates
Comment 1 Caroline Cyr La Rose 2023-06-22 20:10:25 UTC 
Created attachment 152587 [details] [review]
Bug 34103: Capitalization: Currencies & Exchange rates

This patch corrects the breadcrumbs in the Administration > Currencies
and exchange rates page to follow current capitalization and
typographical guidelines.

To test:
0. Apply patch
1. Go to Administration > Currencies and exchange rates
2. Verify that the breadcrumb has no spelling errors, and that
   capitalization and typography guidelines are applied
3. Click 'Delete' next to one of the currencies
4. Verify that the breadcrumb has no spelling errors, and that
   capitalization and typography guidelines are applied
Comment 2 Katrin Fischer 2023-06-22 20:24:02 UTC 
Created attachment 152590 [details] [review]
Bug 34103: Capitalization: Currencies & Exchange rates

This patch corrects the breadcrumbs in the Administration > Currencies
and exchange rates page to follow current capitalization and
typographical guidelines.

To test:
0. Apply patch
1. Go to Administration > Currencies and exchange rates
2. Verify that the breadcrumb has no spelling errors, and that
   capitalization and typography guidelines are applied
3. Click 'Delete' next to one of the currencies
4. Verify that the breadcrumb has no spelling errors, and that
   capitalization and typography guidelines are applied

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2023-06-22 20:24:53 UTC 
Full queue, easy fix, setting to PQA.
Comment 4 Tomás Cohen Arazi (tcohen) 2023-06-23 14:04:08 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize (ashimema) 2023-07-17 14:36:06 UTC 
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Pedro Amorim 2023-07-18 11:55:28 UTC 
Nice work everyone!

Pushed to 22.11.x for next release