Bug 34112 - Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons
Summary: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32910
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-23 13:24 UTC by Owen Leonard
Modified: 2023-07-18 09:45 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons (181.28 KB, patch)
2023-06-23 14:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons (181.54 KB, patch)
2023-06-23 17:32 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons (181.39 KB, patch)
2023-07-07 12:33 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-23 13:24:46 UTC
When working on the upgrade FontAwesome to v.6 I mistakenly replaced "fa-edit" with "fa-pencil-alt". While this works, it's a carry-over from FontAwesome v.5 and may not continue to work.

We should use <i class="fa-solid fa-pencil"></i>
Comment 1 Owen Leonard 2023-06-23 14:15:55 UTC
Created attachment 152639 [details] [review]
Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons

The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5
class. We should use "fa-solid fa-pencil" instead.

This patch also corrects some leftover instances of "fa-edit"

To test, apply the patch and view some pages in the OPAC and staff
interface which have updated icons, e.g.

 - Administration -> Libraries
 - Catalog -> Bibliographic details
 - OPAC -> Bibliographic details

Confirm that the pencil icon looks correct. Checking all modified
templates is probably too much, but inspecting the patch should show
that only fa-pencil-alt and fa-edit icons are affected.
Comment 2 Tomás Cohen Arazi 2023-06-23 17:32:20 UTC
Created attachment 152652 [details] [review]
Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons

The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5
class. We should use "fa-solid fa-pencil" instead.

This patch also corrects some leftover instances of "fa-edit"

To test, apply the patch and view some pages in the OPAC and staff
interface which have updated icons, e.g.

 - Administration -> Libraries
 - Catalog -> Bibliographic details
 - OPAC -> Bibliographic details

Confirm that the pencil icon looks correct. Checking all modified
templates is probably too much, but inspecting the patch should show
that only fa-pencil-alt and fa-edit icons are affected.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Katrin Fischer 2023-07-07 12:33:27 UTC
Created attachment 153172 [details] [review]
Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons

The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5
class. We should use "fa-solid fa-pencil" instead.

This patch also corrects some leftover instances of "fa-edit"

To test, apply the patch and view some pages in the OPAC and staff
interface which have updated icons, e.g.

 - Administration -> Libraries
 - Catalog -> Bibliographic details
 - OPAC -> Bibliographic details

Confirm that the pencil icon looks correct. Checking all modified
templates is probably too much, but inspecting the patch should show
that only fa-pencil-alt and fa-edit icons are affected.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi 2023-07-11 11:52:13 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-18 09:45:28 UTC
Fontawesome 6 not in 23.05.x series, no backport required here.