When working on the upgrade FontAwesome to v.6 I mistakenly replaced "fa-edit" with "fa-pencil-alt". While this works, it's a carry-over from FontAwesome v.5 and may not continue to work. We should use <i class="fa-solid fa-pencil"></i>
Created attachment 152639 [details] [review] Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5 class. We should use "fa-solid fa-pencil" instead. This patch also corrects some leftover instances of "fa-edit" To test, apply the patch and view some pages in the OPAC and staff interface which have updated icons, e.g. - Administration -> Libraries - Catalog -> Bibliographic details - OPAC -> Bibliographic details Confirm that the pencil icon looks correct. Checking all modified templates is probably too much, but inspecting the patch should show that only fa-pencil-alt and fa-edit icons are affected.
Created attachment 152652 [details] [review] Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5 class. We should use "fa-solid fa-pencil" instead. This patch also corrects some leftover instances of "fa-edit" To test, apply the patch and view some pages in the OPAC and staff interface which have updated icons, e.g. - Administration -> Libraries - Catalog -> Bibliographic details - OPAC -> Bibliographic details Confirm that the pencil icon looks correct. Checking all modified templates is probably too much, but inspecting the patch should show that only fa-pencil-alt and fa-edit icons are affected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 153172 [details] [review] Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5 class. We should use "fa-solid fa-pencil" instead. This patch also corrects some leftover instances of "fa-edit" To test, apply the patch and view some pages in the OPAC and staff interface which have updated icons, e.g. - Administration -> Libraries - Catalog -> Bibliographic details - OPAC -> Bibliographic details Confirm that the pencil icon looks correct. Checking all modified templates is probably too much, but inspecting the patch should show that only fa-pencil-alt and fa-edit icons are affected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Fontawesome 6 not in 23.05.x series, no backport required here.