Bug 34124 - Improve in-page navigation on table settings page
Summary: Improve in-page navigation on table settings page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-26 20:27 UTC by Owen Leonard
Modified: 2023-12-12 20:55 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02
Circulation function:


Attachments
Bug 34124: Improve in-page navigation on table settings page (2.78 KB, patch)
2023-06-26 20:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34124: Improve in-page navigation on table settings page (2.82 KB, patch)
2023-06-29 14:56 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34124: Improve in-page navigation on table settings page (2.82 KB, patch)
2023-07-03 10:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34124: Improve in-page navigation on table settings page (2.90 KB, patch)
2023-07-07 06:46 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-26 20:27:56 UTC
We have in-page navigation to jump to specific pages, but we could use in-page navigation to jump directly to tables within pages too.
Comment 1 Owen Leonard 2023-06-26 20:45:00 UTC Comment hidden (obsolete)
Comment 2 Sam Lau 2023-06-29 14:56:24 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2023-07-03 10:49:15 UTC
Created attachment 152926 [details] [review]
Bug 34124: Improve in-page navigation on table settings page

This patch adds links to the table settings page so that the user can
jump directly to a particular table within a page section.

The patch also changes the logic of when in-page links are displayed: I
think it makes sense not to show a "Jump to page" link when there is
only one page. The page will show a "Jump to table" link only if there
is only one table.

To test, apply the patch and go to Administration -> Table settings.

- Expand and check multiple sections.
- In the "Administration" section, there are multiple pages.
  - Check that the "Jump to page" links work correctly.
- In the "Catalog" section, there is only one page: "detail."
  - Check that the "Jump to table" links work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 Jonathan Druart 2023-07-07 06:46:50 UTC
Created attachment 153115 [details] [review]
Bug 34124: Improve in-page navigation on table settings page

This patch adds links to the table settings page so that the user can
jump directly to a particular table within a page section.

The patch also changes the logic of when in-page links are displayed: I
think it makes sense not to show a "Jump to page" link when there is
only one page. The page will show a "Jump to table" link only if there
is only one table.

To test, apply the patch and go to Administration -> Table settings.

- Expand and check multiple sections.
- In the "Administration" section, there are multiple pages.
  - Check that the "Jump to page" links work correctly.
- In the "Catalog" section, there is only one page: "detail."
  - Check that the "Jump to table" links work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-07-07 12:18:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-07-18 09:12:06 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 7 Matt Blenkinsop 2023-07-18 13:44:07 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 8 Caroline Cyr La Rose 2023-12-12 20:55:50 UTC
Nothing to change in the manual that I can see. Feel free to reopen with details if I'm wrong.