---- Reported by nicolas.morin@biblibre.com 2009-07-10 16:02:57 ---- While editing a marc framework, I add a new subfield to a given field. I tick the "repeatable" box and save. My subfield is recorded but as not repeatable. I go back and edit the subfield I just created, ticking the "repeatable" box again. Save. Then my subfield is recorded as being repeatable. I.e. : saving a new subfield as repeatable doesn't work, editing an existing subfield to make it repeatable does work. Tested in Unimarc. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:10 UTC --- This bug was previously known as _bug_ 3413 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3413 Actual time not defined. Setting to 0.0 The original reporter of this bug does not have an account here. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. Previous reporter was nicolas.morin@biblibre.com.
Confirmed in MARC21
This is still a problem in current master.
The 'mandatory' checkbox has the same problem.
Created attachment 9040 [details] [review] Bug 3413: Checkboxes for new subfields not saving correctly The bug was in the numbering of the fields and subfields in the form. The form elements for the 'new subfield' got the same numbered names and ids as the form elements for the second subfield. (example: repeatable1) The patch fixes the numbering to continue to the new subfield. To test: - Create some new subfields and check all checkbox fields save correctly (mandatory, repeatable, is url) - Check that other subfields' checkboxes are not changed - Check existing subfields and newly created subfields can be edited
Created attachment 9236 [details] [review] [SIGNED-OFF] Bug 3413: Checkboxes for new subfields not saving correctly The bug was in the numbering of the fields and subfields in the form. The form elements for the 'new subfield' got the same numbered names and ids as the form elements for the second subfield. (example: repeatable1) The patch fixes the numbering to continue to the new subfield. To test: - Create some new subfields and check all checkbox fields save correctly (mandatory, repeatable, is url) - Check that other subfields' checkboxes are not changed - Check existing subfields and newly created subfields can be edited Signed-off-by: mveron <veron@veron.ch>
Created attachment 9237 [details] [review] [SIGNED-OFF] Bug 3413: Checkboxes for new subfields not saving correctly The bug was in the numbering of the fields and subfields in the form. The form elements for the 'new subfield' got the same numbered names and ids as the form elements for the second subfield. (example: repeatable1) The patch fixes the numbering to continue to the new subfield. To test: - Create some new subfields and check all checkbox fields save correctly (mandatory, repeatable, is url) - Check that other subfields' checkboxes are not changed - Check existing subfields and newly created subfields can be edited Signed-off-by: mveron <veron@veron.ch>
QA Comment: Patch clean, remove useless 'for' statement and uppercase on 'url' strings. Works as expected, marked as Passed QA.
This patch will be in 3.6.6.