Bug 34133 - ILL table should be sorted by request id descending by default
Summary: ILL table should be sorted by request id descending by default
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Pedro Amorim
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-27 14:36 UTC by Nick Clemens (kidclamp)
Modified: 2023-09-13 20:56 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09


Attachments
Bug 34133: Set default sort on first column (ID) desc (840 bytes, patch)
2023-06-27 15:00 UTC, Pedro Amorim
Details | Diff | Splinter Review
Lowest numbers at the top (22.22 KB, image/png)
2023-06-29 06:42 UTC, Magnus Enger
Details
Bug 34133: Set default sort on first column (ID) desc (1.21 KB, patch)
2023-06-30 07:34 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 34133: Set default sort on first column (ID) desc (1.27 KB, patch)
2023-07-17 12:52 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-06-27 14:36:03 UTC
The table saves state, so a user can choose their own. The default should be newest requests first if a user does not set something
Comment 1 Pedro Amorim 2023-06-27 15:00:25 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2023-06-29 06:41:41 UTC Comment hidden (obsolete)
Comment 3 Magnus Enger 2023-06-29 06:42:16 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2023-06-29 07:26:13 UTC
Should this actually be sorting on the placed on date as a posed to ID?
Comment 5 Pedro Amorim 2023-06-29 08:40:26 UTC
Test plan:

Before applying patch:
* Open incognito at /cgi-bin/koha/ill/ill-requests.pl, 
* Verify order is by ASC (lowest ID first)
* Close incognito

Apply patch, then:
* Open incognito at /cgi-bin/koha/ill/ill-requests.pl,
* Verify order is by DESC (highest ID first)

Did the test plan myself on both Google Chrome and Firefox.
Can you please give it another go, Magnus?
Comment 6 Magnus Enger 2023-06-30 07:34:40 UTC
Created attachment 152886 [details] [review]
Bug 34133: Set default sort on first column (ID) desc

Test plan:

Before applying patch:
* Open incognito at /cgi-bin/koha/ill/ill-requests.pl,
* Verify order is by ASC (lowest ID first)
* Close incognito

Apply patch, then:
* Open incognito at /cgi-bin/koha/ill/ill-requests.pl,
* Verify order is by DESC (highest ID first)

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Followed the test plan from Bugzilla, and added it above.
Works as advertised.
Comment 7 Magnus Enger 2023-06-30 07:36:33 UTC
(In reply to Martin Renvoize from comment #4)
> Should this actually be sorting on the placed on date as a posed to ID?

Would that make a difference in practice?
Comment 8 Pedro Amorim 2023-07-17 08:11:50 UTC
Hey guys any chance for a PQA here? Something that needs improving? Thanks!
Comment 9 Nick Clemens (kidclamp) 2023-07-17 12:52:06 UTC
Created attachment 153541 [details] [review]
Bug 34133: Set default sort on first column (ID) desc

Test plan:

Before applying patch:
* Open incognito at /cgi-bin/koha/ill/ill-requests.pl,
* Verify order is by ASC (lowest ID first)
* Close incognito

Apply patch, then:
* Open incognito at /cgi-bin/koha/ill/ill-requests.pl,
* Verify order is by DESC (highest ID first)

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Followed the test plan from Bugzilla, and added it above.
Works as advertised.
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Tomás Cohen Arazi 2023-07-19 15:08:44 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Fridolin Somers 2023-08-04 01:36:43 UTC
Pushed to 23.05.x for 23.05.03
Comment 12 Pedro Amorim 2023-08-18 10:53:41 UTC
Nice work everyone!

Pushed to 22.11.x for next release