Bug 34135 - Show the icons for selected tab to the left of the search bar in the staff interface
Summary: Show the icons for selected tab to the left of the search bar in the staff in...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-27 17:13 UTC by Nick Clemens (kidclamp)
Modified: 2023-09-19 12:19 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Mockup (17.32 KB, image/png)
2023-06-27 17:16 UTC, Nick Clemens (kidclamp)
Details
Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface (70.17 KB, patch)
2023-06-28 12:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface (70.23 KB, patch)
2023-06-28 12:36 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface (70.28 KB, patch)
2023-07-06 22:37 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface (69.87 KB, patch)
2023-09-01 09:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-06-27 17:13:51 UTC
In the new interface the options for different searches have icons on the right side when selecting them

It would be nice to show the icon on the left side of the search box as an extra indicator of the current selection
Comment 1 Nick Clemens (kidclamp) 2023-06-27 17:16:26 UTC
Created attachment 152768 [details]
Mockup

Like this, but better
Comment 2 Owen Leonard 2023-06-28 12:13:24 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2023-06-28 12:16:06 UTC
I wanted to offer this patch for testing to see if other agreed with this change. I think it could be helpful for quick recognition of context for circulation desk users especially.

If folks don't like the additional icons, an alternative would be to show the icon only if the browser width was narrow enough that the form label text is hidden.
Comment 4 Nick Clemens (kidclamp) 2023-06-28 12:36:32 UTC Comment hidden (obsolete)
Comment 5 Nick Clemens (kidclamp) 2023-06-28 12:37:03 UTC
I love it! Leaving NSO for another opinion, but adding my support
Comment 6 Lucas Gass 2023-07-06 22:37:08 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2023-09-01 09:26:07 UTC
Created attachment 155079 [details] [review]
Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface

This patch modifies header search forms so that the form label has the
same icon used by the "tab" link.

The patch also improves the responsive behavior of the header search by
using the icon as the form label when the browser window is narrow
enough to hide the label text.

I've added the "aria-hidden" attribute to other icons in the modified
templates and made the "fa-fw" class consistent for all tab icons.

To test, apply the patch and rebuild the staff interface CSS. Clear your
browser cache if necessary.

View the header search form at various browser sizes to confirm that
content is shown and hidden correctly. Test at least one page which uses
each of the modified header search includes:

 - Staff client home page
 - Acquisitions -> Acquisitions home
   - Vendor ->
     - Basket -> Add to basket -> From suggestion
     - Contracts
 - Administration ->
   - Budgets
   - Currencies
   - Desks (with UseCirculationDesks enabled)
   - System preferences
   - Z39.50/SRU servers
 - Catalog advanced search
   - Search results
 - Authorities -> Authorities home
 - Cataloging -> Cataloging home
 - Circulation -> Check out
 - E-resource management (with ERMModule enabled)
 - Patrons -> Patrons home
 - Serials -> Serials home
 - Tools -> Notices

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Tomás Cohen Arazi 2023-09-01 14:44:42 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-09-08 06:09:35 UTC
Enhancement not pushed to 23.05.x