When configuring the table in the Holds cancellation tab, there is a checkbox missing for Date Cancellation Request. So all the boxes are one off. For example to hide the Title tab, I would have to check the patron box while configuring.
Created attachment 152812 [details] [review] Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column.
Just for clarification, where would I put this information to try the fix?
Created attachment 152840 [details] [review] Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column.
(In reply to quinn.morris from comment #2) > Just for clarification, where would I put this information to try the fix? In case you were referring to an incomplete test plan, I have revised it with more details. If you're asking how to apply and test the patch, check out this page: https://wiki.koha-community.org/wiki/Sandboxes
Created attachment 152841 [details] [review] Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn <quinn.morris@citruslibraries.org>
Created attachment 152842 [details] [review] Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn <quinn.morris@citruslibraries.org>
Thx for testing, Quinn!
The most visible change here is that the Actions columns is now toggable again as the last column of the table. It's included in the yaml, so this seems intentional.
Created attachment 153211 [details] [review] Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn <quinn.morris@citruslibraries.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x