Bug 34137 - Requested cancellation date column missing from holds awaiting pickup table config
Summary: Requested cancellation date column missing from holds awaiting pickup table c...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-27 19:54 UTC by quinn.morris
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config (1.61 KB, patch)
2023-06-28 15:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config (2.07 KB, patch)
2023-06-28 19:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config (2.13 KB, patch)
2023-06-28 20:54 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config (2.13 KB, patch)
2023-06-28 20:54 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config (2.18 KB, patch)
2023-07-09 13:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description quinn.morris 2023-06-27 19:54:34 UTC
When configuring the table in the Holds cancellation tab, there is a checkbox missing for Date Cancellation Request. So all the boxes are one off. For example to hide the Title tab, I would have to check the patron box while configuring.
Comment 1 Owen Leonard 2023-06-28 15:14:15 UTC Comment hidden (obsolete)
Comment 2 quinn.morris 2023-06-28 15:36:04 UTC
Just for clarification, where would I put this information to try the fix?
Comment 3 Owen Leonard 2023-06-28 19:28:23 UTC
Created attachment 152840 [details] [review]
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config

This patch adds an entry for the requested cancellation date column to
columns_settings.yml so that the column can be configured correctly in
table settings and on the fly.

To test you will need at least one hold with a cancellation request:

- Go to Administration -> Circulation and fine rules -> Default waiting
  hold cancellation policy
  - Add at least one rule allowing cancellation on waiting items.
- Place a hold for a patron which would fall under the rule you defined.
- Satisfy the hold by checking the item in at the hold's destination
  location.
- Cancel the hold, either by logging in to the OPAC as the patron with
  the hold, or in the staff client via the holds tab on the patron's
  record.

- Apply the patch and restart all services.
- Go to Circulation -> Holds awaiting pickup
- In the "Holds with cancellation requests" tab, confirm that there is a
  "Date cancellation requested" column and that it is one of the choices
  under the "Columns" button.
- Confirm that the correct columns are shown and hidden when making
  selections in the columns menu.
- Go to Administration -> Table settings -> Circulation -> Holds
  awaiting pickup.
   - Test setting "Is hidden by default" and "Cannot be toggled" for
     various columns in the table, including the "Date cancellation
     requested" column.
Comment 4 Owen Leonard 2023-06-28 19:30:41 UTC
(In reply to quinn.morris from comment #2)
> Just for clarification, where would I put this information to try the fix?

In case you were referring to an incomplete test plan, I have revised it with more details.

If you're asking how to apply and test the patch, check out this page: https://wiki.koha-community.org/wiki/Sandboxes
Comment 5 ByWater Sandboxes 2023-06-28 20:54:03 UTC
Created attachment 152841 [details] [review]
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config

This patch adds an entry for the requested cancellation date column to
columns_settings.yml so that the column can be configured correctly in
table settings and on the fly.

To test you will need at least one hold with a cancellation request:

- Go to Administration -> Circulation and fine rules -> Default waiting
  hold cancellation policy
  - Add at least one rule allowing cancellation on waiting items.
- Place a hold for a patron which would fall under the rule you defined.
- Satisfy the hold by checking the item in at the hold's destination
  location.
- Cancel the hold, either by logging in to the OPAC as the patron with
  the hold, or in the staff client via the holds tab on the patron's
  record.

- Apply the patch and restart all services.
- Go to Circulation -> Holds awaiting pickup
- In the "Holds with cancellation requests" tab, confirm that there is a
  "Date cancellation requested" column and that it is one of the choices
  under the "Columns" button.
- Confirm that the correct columns are shown and hidden when making
  selections in the columns menu.
- Go to Administration -> Table settings -> Circulation -> Holds
  awaiting pickup.
   - Test setting "Is hidden by default" and "Cannot be toggled" for
     various columns in the table, including the "Date cancellation
     requested" column.

Signed-off-by: Quinn <quinn.morris@citruslibraries.org>
Comment 6 ByWater Sandboxes 2023-06-28 20:54:37 UTC
Created attachment 152842 [details] [review]
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config

This patch adds an entry for the requested cancellation date column to
columns_settings.yml so that the column can be configured correctly in
table settings and on the fly.

To test you will need at least one hold with a cancellation request:

- Go to Administration -> Circulation and fine rules -> Default waiting
  hold cancellation policy
  - Add at least one rule allowing cancellation on waiting items.
- Place a hold for a patron which would fall under the rule you defined.
- Satisfy the hold by checking the item in at the hold's destination
  location.
- Cancel the hold, either by logging in to the OPAC as the patron with
  the hold, or in the staff client via the holds tab on the patron's
  record.

- Apply the patch and restart all services.
- Go to Circulation -> Holds awaiting pickup
- In the "Holds with cancellation requests" tab, confirm that there is a
  "Date cancellation requested" column and that it is one of the choices
  under the "Columns" button.
- Confirm that the correct columns are shown and hidden when making
  selections in the columns menu.
- Go to Administration -> Table settings -> Circulation -> Holds
  awaiting pickup.
   - Test setting "Is hidden by default" and "Cannot be toggled" for
     various columns in the table, including the "Date cancellation
     requested" column.

Signed-off-by: Quinn <quinn.morris@citruslibraries.org>
Comment 7 Katrin Fischer 2023-07-09 12:55:48 UTC
Thx for testing, Quinn!
Comment 8 Katrin Fischer 2023-07-09 13:01:24 UTC
The most visible change here is that the Actions columns is now toggable again as the last column of the table. It's included in the yaml, so this seems intentional.
Comment 9 Katrin Fischer 2023-07-09 13:01:57 UTC
Created attachment 153211 [details] [review]
Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config

This patch adds an entry for the requested cancellation date column to
columns_settings.yml so that the column can be configured correctly in
table settings and on the fly.

To test you will need at least one hold with a cancellation request:

- Go to Administration -> Circulation and fine rules -> Default waiting
  hold cancellation policy
  - Add at least one rule allowing cancellation on waiting items.
- Place a hold for a patron which would fall under the rule you defined.
- Satisfy the hold by checking the item in at the hold's destination
  location.
- Cancel the hold, either by logging in to the OPAC as the patron with
  the hold, or in the staff client via the holds tab on the patron's
  record.

- Apply the patch and restart all services.
- Go to Circulation -> Holds awaiting pickup
- In the "Holds with cancellation requests" tab, confirm that there is a
  "Date cancellation requested" column and that it is one of the choices
  under the "Columns" button.
- Confirm that the correct columns are shown and hidden when making
  selections in the columns menu.
- Go to Administration -> Table settings -> Circulation -> Holds
  awaiting pickup.
   - Test setting "Is hidden by default" and "Cannot be toggled" for
     various columns in the table, including the "Date cancellation
     requested" column.

Signed-off-by: Quinn <quinn.morris@citruslibraries.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2023-07-10 18:43:20 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Martin Renvoize 2023-07-18 09:33:41 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 12 Matt Blenkinsop 2023-07-18 14:07:20 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x