Created attachment 153021 [details] Screenshot showing which title to change When viewing funds in acquisitions administration, there is a filter box on the left of the screen. The "title" of this box is... underwhelming? It looks like there is a style missing. To access: 1. Go to Administration > Funds --> On the left, there is a white box with a title "Fund filter", and just above that box is a "Filters" title that doesn't look like it has any styling. I have added a screenshot with an arrow pointing to the "Filters" title, in case my description is not clear. Since the box already has a title "Fund filter", the "Filters" title could be removed. Or the "Refine your search" box when viewing search results could be an example to follow. It tops the box in green. To access: 1. Make a search in the catalog --> On the left, above the facets is the "title" of the box
Created attachment 153499 [details] [review] Bug 34196: Improve styling of sidebar form on funds admin page This patch makes a few markup changes to the sidebar filter form on the funds administration page in order to make it more usable and more consistent with other similar forms. The patch removes the link for expanding and collapsing the sidebar filter because it looked bad and was inconsistent with all similar forms. To test, apply the patch and go to Administration -> Funds. Confirm that the sidebar form looks correct. Compare to, for example, the sidebar form at Acquisitions -> Invoices.
Created attachment 153511 [details] [review] Bug 34196: Improve styling of sidebar form on funds admin page This patch makes a few markup changes to the sidebar filter form on the funds administration page in order to make it more usable and more consistent with other similar forms. The patch removes the link for expanding and collapsing the sidebar filter because it looked bad and was inconsistent with all similar forms. To test, apply the patch and go to Administration -> Funds. Confirm that the sidebar form looks correct. Compare to, for example, the sidebar form at Acquisitions -> Invoices. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Is it normal that the invoices search filters is h3 and funds search filters is h4? (And also that in both cases there are no h2?) Otherwise, I think it looks much better!
Created attachment 155077 [details] [review] Bug 34196: Improve styling of sidebar form on funds admin page This patch makes a few markup changes to the sidebar filter form on the funds administration page in order to make it more usable and more consistent with other similar forms. The patch removes the link for expanding and collapsing the sidebar filter because it looked bad and was inconsistent with all similar forms. To test, apply the patch and go to Administration -> Funds. Confirm that the sidebar form looks correct. Compare to, for example, the sidebar form at Acquisitions -> Invoices. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.11. Nice work everyone, thanks!
Not backported to 23.05.x