Bug 34196 - UI adjustment to filters on funds administration page
Summary: UI adjustment to filters on funds administration page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-04 19:52 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Screenshot showing which title to change (48.81 KB, image/png)
2023-07-04 19:52 UTC, Caroline Cyr La Rose
Details
Bug 34196: Improve styling of sidebar form on funds admin page (3.06 KB, patch)
2023-07-14 18:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34196: Improve styling of sidebar form on funds admin page (3.12 KB, patch)
2023-07-16 10:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34196: Improve styling of sidebar form on funds admin page (3.19 KB, patch)
2023-09-01 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-04 19:52:36 UTC
Created attachment 153021 [details]
Screenshot showing which title to change

When viewing funds in acquisitions administration, there is a filter box on the left of the screen. The "title" of this box is... underwhelming? It looks like there is a style missing.

To access:
1. Go to Administration > Funds
--> On the left, there is a white box with a title "Fund filter", and just above that box is a "Filters" title that doesn't look like it has any styling.

I have added a screenshot with an arrow pointing to the "Filters" title, in case my description is not clear.

Since the box already has a title "Fund filter", the "Filters" title could be removed.

Or the "Refine your search" box when viewing search results could be an example to follow. It tops the box in green.
To access:
1. Make a search in the catalog
--> On the left, above the facets is the "title" of the box
Comment 1 Owen Leonard 2023-07-14 18:16:54 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2023-07-16 10:49:45 UTC Comment hidden (obsolete)
Comment 3 Caroline Cyr La Rose 2023-08-07 15:42:23 UTC
Is it normal that the invoices search filters is h3 and funds search filters is h4? (And also that in both cases there are no h2?)

Otherwise, I think it looks much better!
Comment 4 Jonathan Druart 2023-09-01 09:20:32 UTC
Created attachment 155077 [details] [review]
Bug 34196: Improve styling of sidebar form on funds admin page

This patch makes a few markup changes to the sidebar filter form on the
funds administration page in order to make it more usable and more
consistent with other similar forms.

The patch removes the link for expanding and collapsing the sidebar
filter because it looked bad and was inconsistent with all similar
forms.

To test, apply the patch and go to Administration -> Funds. Confirm that
the sidebar form looks correct. Compare to, for example, the sidebar
form at Acquisitions -> Invoices.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-09-05 14:53:39 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 06:34:28 UTC
Not backported to 23.05.x