Bug 34197 - Group and label vendor contact settings
Summary: Group and label vendor contact settings
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-04 20:48 UTC by Caroline Cyr La Rose
Modified: 2023-11-10 15:00 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/750
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34197: Group and label vendor contact settings (21.23 KB, patch)
2023-07-19 13:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34197: Group and label vendor contact settings (21.30 KB, patch)
2023-07-19 14:01 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34197: Group and label vendor contact settings (21.35 KB, patch)
2023-07-31 21:13 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-04 20:48:01 UTC
When adding a vendor, you can add contacts for this vendor. In the contact form, there is a list of checkboxes where some are about acquisitions and some are about serials, mixed together.

I wonder if it would be possible to change this into either two columns or two sub-sections, separating the acquisitions and serial options?

Acquisitions options:
- Primary acquisitions contact
- Contact when ordering?
- Contact about late orders?

Serials options:
- Primary serials contact
- Contact about late issues?

I always find it weird to explain in training, this one is for acquisitions and this one is for serials and this one is for acquisitions, etc.
Comment 1 Owen Leonard 2023-07-19 13:44:08 UTC
Created attachment 153650 [details] [review]
Bug 34197: Group and label vendor contact settings

This patch changes the layout of vendor contact settings, both in the
entry form and in the detail view. Now acquisitions-specific contact
settings and serials-specific contact settings are grouped together and
labeled as such.

The patch also corrects some markup to make the display more consistent.
JS handling of some labels has been removed because the structure change
eliminated the need for a "for" attribute.

The patch also makes a minor unrelated change to the display of discount
percentages to ensure that a blank value doesn't display.

To test, apply the patch and go to Acquisitions -> New vendor.

- In the vendor entry form, in the "Contacts" section, you should see
  two groups of checkboxes, "Acquisitions options" and "Serials
  options." Confirm that the labels can be clicked to check checkboxes.
- Test the process of adding another contact and confirm that the
  additional entry fields work correctly.
  - Confirm that the "Primary acquisitions contact" and "Primary serials
    contact" checkboxes act like radio buttons between the two contacts:
    Checking the box under one contact should uncheck the same box under
    the other contact.
- Confirm that all your data is saved correctly.
- Test the page during the edit process as well.
- View your updated vendor and confirm that the detail view looks
  correct.
Comment 2 Caroline Cyr La Rose 2023-07-19 14:01:12 UTC
Created attachment 153652 [details] [review]
Bug 34197: Group and label vendor contact settings

This patch changes the layout of vendor contact settings, both in the
entry form and in the detail view. Now acquisitions-specific contact
settings and serials-specific contact settings are grouped together and
labeled as such.

The patch also corrects some markup to make the display more consistent.
JS handling of some labels has been removed because the structure change
eliminated the need for a "for" attribute.

The patch also makes a minor unrelated change to the display of discount
percentages to ensure that a blank value doesn't display.

To test, apply the patch and go to Acquisitions -> New vendor.

- In the vendor entry form, in the "Contacts" section, you should see
  two groups of checkboxes, "Acquisitions options" and "Serials
  options." Confirm that the labels can be clicked to check checkboxes.
- Test the process of adding another contact and confirm that the
  additional entry fields work correctly.
  - Confirm that the "Primary acquisitions contact" and "Primary serials
    contact" checkboxes act like radio buttons between the two contacts:
    Checking the box under one contact should uncheck the same box under
    the other contact.
- Confirm that all your data is saved correctly.
- Test the page during the edit process as well.
- View your updated vendor and confirm that the detail view looks
  correct.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2023-07-19 14:02:02 UTC
I love it! It looks much nicer and I think it's clearer what is what.
Comment 4 Katrin Fischer 2023-07-31 21:13:35 UTC
Created attachment 154119 [details] [review]
Bug 34197: Group and label vendor contact settings

This patch changes the layout of vendor contact settings, both in the
entry form and in the detail view. Now acquisitions-specific contact
settings and serials-specific contact settings are grouped together and
labeled as such.

The patch also corrects some markup to make the display more consistent.
JS handling of some labels has been removed because the structure change
eliminated the need for a "for" attribute.

The patch also makes a minor unrelated change to the display of discount
percentages to ensure that a blank value doesn't display.

To test, apply the patch and go to Acquisitions -> New vendor.

- In the vendor entry form, in the "Contacts" section, you should see
  two groups of checkboxes, "Acquisitions options" and "Serials
  options." Confirm that the labels can be clicked to check checkboxes.
- Test the process of adding another contact and confirm that the
  additional entry fields work correctly.
  - Confirm that the "Primary acquisitions contact" and "Primary serials
    contact" checkboxes act like radio buttons between the two contacts:
    Checking the box under one contact should uncheck the same box under
    the other contact.
- Confirm that all your data is saved correctly.
- Test the page during the edit process as well.
- View your updated vendor and confirm that the detail view looks
  correct.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-08-15 09:13:54 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-08-17 20:06:58 UTC
Enhancement not pushed to 23.05.x
Comment 7 Caroline Cyr La Rose 2023-11-10 15:00:31 UTC
Screenshot was updated in the manual.