Bug 34201 - Missing sorting indicator on the ERM tables
Summary: Missing sorting indicator on the ERM tables
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 33973
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-05 11:45 UTC by Jonathan Druart
Modified: 2023-12-28 20:46 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34201: Restore sorting indicator on ERM tables (1.59 KB, patch)
2023-07-05 11:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34201: Restore sorting indicator on ERM tables (1.63 KB, patch)
2023-07-05 16:31 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34201: (follow-up) Add additional specific CSS (2.38 KB, patch)
2023-07-05 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34201: (follow-up) Add additional specific CSS (2.43 KB, patch)
2023-07-05 18:47 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34201: Restore sorting indicator on ERM tables (1.69 KB, patch)
2023-07-07 13:46 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-07-05 11:45:10 UTC
See commit message from bug 

"""
Note that the CSS is not correct yet. My understanding is that the
DataTable Vue component keep the 'sorting' class on the th which display
the grey up/down icon over the blue icon which indicate the current sort
column.
"""
Comment 1 Jonathan Druart 2023-07-05 11:50:03 UTC
Created attachment 153053 [details] [review]
Bug 34201: Restore sorting indicator on ERM tables

DataTable Vue component keep the 'sorting' class on the th which display
the grey up/down icon over the blue icon which indicate the current sort
column

Test plan:
Create several agreements, notice that the list view is having the
sorting indicators (blue arrows) in the top right of the first column.
Sort the columns: asc, desc, combined sort (shift+click) and confirm
that the indicators are correct
Comment 2 Jonathan Druart 2023-07-05 11:51:10 UTC
Don't forget to regenerate the CSS files: `yarn css:build`
Comment 3 Sam Lau 2023-07-05 16:31:54 UTC
Created attachment 153068 [details] [review]
Bug 34201: Restore sorting indicator on ERM tables

DataTable Vue component keep the 'sorting' class on the th which display
the grey up/down icon over the blue icon which indicate the current sort
column

Test plan:
Create several agreements, notice that the list view is having the
sorting indicators (blue arrows) in the top right of the first column.
Sort the columns: asc, desc, combined sort (shift+click) and confirm
that the indicators are correct

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 Owen Leonard 2023-07-05 16:48:10 UTC Comment hidden (obsolete)
Comment 5 Sam Lau 2023-07-05 18:47:06 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2023-07-06 12:51:27 UTC
@QA: please confirm this second patch is really needed. Sorting indicators are correctly displayed on Vue and non-Vue DT tables without it for me.
Comment 7 Owen Leonard 2023-07-06 12:54:54 UTC
Re-testing this today I find you're correct. My patch is not necessary.
Comment 8 Pedro Amorim 2023-07-07 13:46:52 UTC
Created attachment 153182 [details] [review]
Bug 34201: Restore sorting indicator on ERM tables

DataTable Vue component keep the 'sorting' class on the th which display
the grey up/down icon over the blue icon which indicate the current sort
column

Test plan:
Create several agreements, notice that the list view is having the
sorting indicators (blue arrows) in the top right of the first column.
Sort the columns: asc, desc, combined sort (shift+click) and confirm
that the indicators are correct

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 9 Tomás Cohen Arazi 2023-07-07 15:12:13 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Martin Renvoize 2023-07-18 09:24:47 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 11 Matt Blenkinsop 2023-07-18 13:46:41 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x