Created attachment 153075 [details] [review] Bug 28726: Follow up - move whole 'select all ...' div into checkbox column condition In the patron search popup from pages that don't have a checkbox in the search results table there is an empty div above the table. This div holds the 'Select all ...' features when there is a checkbox column in the table.
Thanks, Michael.
Created attachment 153350 [details] [review] Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition Move the whole search header div into the checkbox column condition, so that other patron search popups don't have an empty div. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 153388 [details] [review] Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition Move the whole search header div into the checkbox column condition, so that other patron search popups don't have an empty div. To test: * Activate the ERM module * Create a new agreement * Search for a user using the pop-up search * Verify there is an empty div showing as grey box above the table * Go to tools > label creator > new batch * Search for patrons * Verify the box isn't empty and shows the select all ... options * Apply patch * Repeat steps, verify the empty div is gone and the options remain Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please make sure to add a test plan to your patches, working out what I need to test/look at without many hints costs time I cannot spend elsewhere.
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x