Bug 34213 - False POD for matchpoint option in import_patrons.pl
Summary: False POD for matchpoint option in import_patrons.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-06 06:46 UTC by Igor A. Sychev
Modified: 2023-12-28 20:47 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09,22.05.16


Attachments
Bug 34213: import_patrons.pl - Fix short version of matchpoint option in POD (913 bytes, patch)
2023-07-06 12:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34213: import_patrons.pl - Fix short version of matchpoint option in POD (1009 bytes, patch)
2023-07-21 07:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Igor A. Sychev 2023-07-06 06:46:32 UTC
Option "-c" --confirm or --matchpoint?

root@koha:/usr/share/koha/bin# perl import_patrons.pl --help
Usage:
    import_patrons.pl --file /path/to/patrons.csv --matchpoint cardnumber
    --confirm [--default branchcode=MPL] [--overwrite] [--preserve-field
    <column>] [--preserve-extended-attributes] [--update-expiration]
    [--expiration-from-today] [--verbose]

Options:
    -h|--help
            Prints a brief help message and exits

    -c|--confirm
            Confirms you really want to import these patrons, otherwise
            prints this help

    -f|--file
            Path to the CSV file of patrons to import

    -c|--matchpoint
            Field on which to match incoming patrons to existing patrons

    -d|--default
            Set defaults to patron fields, repeatable e.g. --default
            branchcode=MPL --default categorycode=PT

    -k|--preserve-field
            Prevent specified patron fields for existing patrons from being
            overwritten

    -o|--overwrite
            Overwrite existing patrons with new data if a match is found

    -p|--preserve-extended-attributes
            Retain extended patron attributes for existing patrons being
            overwritten

    -en|--email-new
            Send the WELCOME notice email to new users

    -ue|--update-expiration
            If a matching patron is found, extend the expiration date of
            their account using the patron's enrollment date as the base

    -et|--expiration-from-today
            If a matching patron is found, extend the expiration date of
            their account using the patron's enrollment date as the base

    -v|--verbose
            Be verbose

            Multiple -v options increase the verbosity

            2 repetitions or above will report lines in error

            3 repetitions or above will report feedback
Comment 1 Jonathan Druart 2023-07-06 12:56:10 UTC
Created attachment 153094 [details] [review]
Bug 34213: import_patrons.pl - Fix short version of matchpoint option in POD

44     'c|confirm'                      => \$confirm,

 46     'm|matchpoint=s'                 => \$matchpoint,

The POD is wrong.
Comment 2 Marcel de Rooy 2023-07-21 07:49:24 UTC
Created attachment 153757 [details] [review]
Bug 34213: import_patrons.pl - Fix short version of matchpoint option in POD

44     'c|confirm'                      => \$confirm,

 46     'm|matchpoint=s'                 => \$matchpoint,

The POD is wrong.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Tomás Cohen Arazi 2023-07-21 20:15:28 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 4 Fridolin Somers 2023-08-04 02:09:19 UTC
More a fix than enhancement I'd say ;)

Pushed to 23.05.x for 23.05.03
Comment 5 Pedro Amorim 2023-08-18 13:46:31 UTC
Nice work everyone!

Pushed to 22.11.x for next release
Comment 6 Lucas Gass 2023-09-13 21:05:21 UTC
Backported to 22.05.x for upcoming 22.05.16