To reproduce: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber.
Created attachment 153206 [details] [review] Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib.
Created attachment 153262 [details] [review] Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib. Works as advertised. Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com>
Created attachment 153303 [details] [review] Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib. Works as advertised. Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x