Bug 34232 - Item groups dropdown on add item form does not respect display order
Summary: Item groups dropdown on add item form does not respect display order
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal with 10 votes (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-07 19:30 UTC by Lucas Gass
Modified: 2023-10-27 20:22 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34232: Make dropdown on additem page rescept display order (1.46 KB, patch)
2023-07-07 19:32 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34232: Make dropdown on additem page rescept display order (1.53 KB, patch)
2023-07-07 20:33 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 34232: Make dropdown on additem page rescept display order (1.59 KB, patch)
2023-07-10 21:32 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34232: (QA follow-up) Remove superfluous "Use:" from each list entry (1.41 KB, patch)
2023-07-10 21:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-07-07 19:30:30 UTC
To recreate:

1. EnableItemGroups
2. Find a record and add some new item groups with different display orders
3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group"
4. Notice that the values in the dropdown do not respect the display order.
Comment 1 Lucas Gass 2023-07-07 19:32:42 UTC
Created attachment 153203 [details] [review]
Bug 34232: Make dropdown on additem page rescept display order

To test:
1. EnableItemGroups
2. Find a record and add some new item groups with different display orders
3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group"
4. Notice that the values in the dropdown do not respect the display order.
5. Apply patch and restart_all
6. The display order should now be respected
Comment 2 Emily Lamancusa 2023-07-07 20:33:04 UTC
Created attachment 153204 [details] [review]
Bug 34232: Make dropdown on additem page rescept display order

To test:
1. EnableItemGroups
2. Find a record and add some new item groups with different display orders
3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group"
4. Notice that the values in the dropdown do not respect the display order.
5. Apply patch and restart_all
6. The display order should now be respected

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 3 Katrin Fischer 2023-07-10 21:30:29 UTC
I am only seeing the option to add the item to an item group when adding a new item, is that intended?
Comment 4 Katrin Fischer 2023-07-10 21:32:57 UTC
Created attachment 153304 [details] [review]
Bug 34232: Make dropdown on additem page rescept display order

To test:
1. EnableItemGroups
2. Find a record and add some new item groups with different display orders
3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group"
4. Notice that the values in the dropdown do not respect the display order.
5. Apply patch and restart_all
6. The display order should now be respected

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-07-10 21:32:59 UTC
Created attachment 153305 [details] [review]
Bug 34232: (QA follow-up) Remove superfluous "Use:" from each list entry

We do have a heading "Use existing item groups" above the
entries. The added "Use:" in front of each entry is not requires and
makes entries longer and harder to scan.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-07-10 21:34:45 UTC
Note: this is just one spot, we need to fix the others as well, like:
Bug 34234 - Item groups dropdown in detail.tt modal does not respect display order
Comment 7 Tomás Cohen Arazi 2023-07-14 18:24:27 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Martin Renvoize 2023-07-18 11:52:35 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 9 Matt Blenkinsop 2023-07-18 15:29:09 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 10 Owen Leonard 2023-09-13 10:37:04 UTC
*** Bug 34234 has been marked as a duplicate of this bug. ***
Comment 11 Miranda Nero 2023-10-27 19:26:35 UTC
If we are already on 22.11, are we supposed to be seeing this work correctly? It's not for us.
Comment 12 Emily Lamancusa 2023-10-27 19:34:41 UTC
(In reply to Miranda Nero from comment #11)
> If we are already on 22.11, are we supposed to be seeing this work
> correctly? It's not for us.

If you're on 22.11.08 or higher, then it should be working, but if you're on 22.11.07 or earlier, then it wouldn't be. Note that this fixes only the form for creating a new item - there's also bug 34234 (which hasn't been fixed yet) for the dialog box you get when adding an existing item to an item group.
Comment 13 Miranda Nero 2023-10-27 20:22:58 UTC
Oh gotcha, thanks. I was looking at the drop down menu from that other bug.