Bug 34243 - Too many cities are created (at least in comments)
Summary: Too many cities are created (at least in comments)
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-10 09:50 UTC by Marcel de Rooy
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.,22.05.16
Circulation function:

Attachments
Bug 34243: Fix copy/pasted city references in api tests (1.62 KB, patch)
2023-07-12 14:55 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-07-10 09:50:13 UTC 

    


    


      



        
          Comment 1
        

        
          Marcel de Rooy

        

        
        

        
          2023-07-12 14:55:45 UTC
        

      






Created attachment 153368 [details] [review]
Bug 34243: Fix copy/pasted city references in api tests

Two occurrences.
Just comments.

Test plan:
Read the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

    


    


      



        
          Comment 2
        

        
          Marcel de Rooy

        

        
        

        
          2023-07-12 14:56:26 UTC
        

      






This is a QA follow-up actually..

    


    


      



        
          Comment 3
        

        
          Marcel de Rooy

        

        
        

        
          2023-07-14 06:31:59 UTC
        

      






 OK     t/db_dependent/api/v1/smtp_servers.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     t/db_dependent/api/v1/suggestions.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

    


    


      



        
          Comment 4
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2023-07-14 12:01:27 UTC
        

      






Pushed to master for 23.11.

Nice work everyone, thanks!

    


    


      



        
          Comment 5
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2023-07-18 11:52:38 UTC
        

      






Thanks for all the hard work!

Pushed to 23.05.x for the next release

    


    


      



        
          Comment 6
        

        
          Matt Blenkinsop

        

        
        

        
          2023-07-18 15:29:12 UTC
        

      






Nice work everyone!

Pushed to oldstable for 22.11.x

    


    


      



        
          Comment 7
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2023-09-13 20:26:48 UTC
        

      






Backported to 22.05.x for upcoming 22.05.16