Bug 34275 - Add a button to easily toggle between advanced/basic cataloging editors
Summary: Add a button to easily toggle between advanced/basic cataloging editors
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 35651
  Show dependency treegraph
 
Reported: 2023-07-13 17:50 UTC by Lucas Gass
Modified: 2023-12-27 17:57 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
When the advanced cataloging editor is activated using `EnableAdvancedCatalogingEditor`, there is now a nice toggle button in the upper right corner of the cataloguing module when editing a record that allows to easily switch between the normal and the advanced editor.
Version(s) released in:
23.11.00


Attachments
Bug 34275: Add toggle switch for basic/advanced cataloging editors (13.61 KB, patch)
2023-07-13 17:57 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (13.65 KB, patch)
2023-07-16 14:52 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (9.83 KB, patch)
2023-08-16 21:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (9.88 KB, patch)
2023-08-16 21:52 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (9.69 KB, patch)
2023-09-15 17:46 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (9.75 KB, patch)
2023-09-22 18:55 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (9.75 KB, patch)
2023-09-22 19:05 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (2.13 KB, patch)
2023-10-31 15:59 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34275: (follow-up) Restore the rest of the changes (1.29 KB, patch)
2023-11-06 15:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34275: Add toggle switch for basic/advanced cataloging editors (9.10 KB, patch)
2023-11-06 17:53 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-07-13 17:50:15 UTC
Some librarians/catalogers would find it handy if there was a way to more easily toggle between the advanced and basic cataloging editors.
Comment 1 Lucas Gass 2023-07-13 17:57:37 UTC
Created attachment 153426 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.
Comment 2 ByWater Sandboxes 2023-07-16 14:52:41 UTC
Created attachment 153522 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Barbara Johnson 2023-07-16 14:53:35 UTC
This works great and will be a timesaver.
Comment 4 Phil Ringnalda 2023-08-09 01:55:03 UTC
Looks like you accidentally included something from work on another patch, since the hunk commenting out part of koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt doesn't fit this bug.
Comment 5 Lucas Gass 2023-08-16 21:31:53 UTC
Created attachment 154471 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 6 Lucas Gass 2023-08-16 21:37:50 UTC
(In reply to Phil Ringnalda from comment #4)
> Looks like you accidentally included something from work on another patch,
> since the hunk commenting out part of
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt doesn't fit
> this bug.

Good catch Phil, thanks!
Comment 7 Phil Ringnalda 2023-08-16 21:52:10 UTC
Created attachment 154472 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 8 Martin Renvoize 2023-08-17 12:48:40 UTC
Whilst the functionality here works nicely, I'm not sure about the styling myself.

I think I'd either prefer a 'Switch to X editor' button that contextually sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle switch rather than the large toggle the includes the text within it.

Tagging Owen for that more artistic eye ;P
Comment 9 Lucas Gass 2023-08-25 21:20:40 UTC
(In reply to Martin Renvoize from comment #8)
> Whilst the functionality here works nicely, I'm not sure about the styling
> myself.
> 
> I think I'd either prefer a 'Switch to X editor' button that contextually
> sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle
> switch rather than the large toggle the includes the text within it.
> 
> Tagging Owen for that more artistic eye ;P

That makes sense. I'll come back to this one ASAP. For now I'll set to FQA.
Comment 10 Lucas Gass 2023-09-15 17:46:48 UTC
Created attachment 155706 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.
Comment 11 Lucas Gass 2023-09-15 17:47:44 UTC
(In reply to Martin Renvoize from comment #8)
> Whilst the functionality here works nicely, I'm not sure about the styling
> myself.
> 
> I think I'd either prefer a 'Switch to X editor' button that contextually
> sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle
> switch rather than the large toggle the includes the text within it.
> 
> Tagging Owen for that more artistic eye ;P

Martin, maybe my latest patch is more in line with what you envision?
Comment 12 ByWater Sandboxes 2023-09-22 18:55:29 UTC
Created attachment 156124 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.

Signed-off-by: Eesther <esther@bywatersolutions.com>
Comment 13 Brendan Lawlor 2023-09-22 19:05:08 UTC
Created attachment 156125 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 14 Katrin Fischer 2023-10-31 15:57:21 UTC
I was about to say, I don't like the GUI implementation... and then the yarn build kicked in :)
Comment 15 Katrin Fischer 2023-10-31 15:59:54 UTC
Created attachment 158142 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.

Signed-off-by: Eesther <esther@bywatersolutions.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Tomás Cohen Arazi 2023-11-03 17:23:16 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Katrin Fischer 2023-11-05 00:26:07 UTC
Somehow the new nice styling is missing for me, even after running yarn build and restart all on current master.
Comment 18 Martin Renvoize 2023-11-06 11:29:52 UTC
This looks like there's patches missing here to me... the one patch on the bug now only adds a template block with a checkbox.. I'm not seeing the actually functionality tied to it anywhere.. or the css
Comment 19 Katrin Fischer 2023-11-06 12:17:48 UTC
I am not sure how the patch got mangled, but apparently it did. Can we restore the missing files from the original patch?
Comment 20 Lucas Gass 2023-11-06 15:31:04 UTC
Created attachment 158537 [details] [review]
Bug 34275: (follow-up) Restore the rest of the changes
Comment 21 Lucas Gass 2023-11-06 17:53:05 UTC
Created attachment 158538 [details] [review]
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it works correecly.
6. Try editing an existing record and make sure the toggle works well when editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present.

Signed-off-by: Eesther <esther@bywatersolutions.com>
Comment 22 Katrin Fischer 2023-11-06 18:57:24 UTC
Thank you, Lucas! I can confirm it looks and works nicely now in current dev version.
Comment 23 Fridolin Somers 2023-11-10 06:52:35 UTC
Enhancement not pushed to 23.05.x