---- Reported by maria.laude@liblime.com 2009-07-20 17:01:51 ---- Looks like report is pulling from holdingbranch, not homebranch as expected. Either add description to report or change to homebranch, which is what typical user would expect. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:10 UTC --- This bug was previously known as _bug_ 3431 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3431 Actual time not defined. Setting to 0.0 The original reporter of this bug does not have an account here. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. Previous reporter was maria.laude@liblime.com. CC member maria.laude@liblime.com does not have an account here
Created attachment 5110 [details] [review] Proposed fix Several fixes for this report no one uses: - Clarifying titles and breadcrumbs - Correcting terminology: branch -> library - Sorting library select field by library name - Displaying library name instead of code on output - Sorting results by itemtype description - Adding tablesorter to results
Oh, and here's why I clarified the description instead of changing the query to pull homebranch. I see this as a report of items *held* at your library, not owned. But it's okay, no one uses this report anyway.
I agree this report is not used, but the changes made make it more useful to never use. Will sign off
Created attachment 6715 [details] [review] Fix for Bug 3431 - Catalog by itemtype report pulling from holdingbranch Plus several other fixes for this report no one uses: - Clarifying titles and breadcrumbs - Correcting terminology: branch -> library - Sorting library select field by library name - Displaying library name instead of code on output - Sorting results by itemtype description - Adding tablesorter to results Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
QA comment: clean code, passes perlcritic, clarify report passed QA patch pushed, please test