Bug 34322 - Correct icon triggering more fund search options
Summary: Correct icon triggering more fund search options
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32910
Blocks: 34323
  Show dependency treegraph
 
Reported: 2023-07-20 12:15 UTC by Owen Leonard
Modified: 2023-09-19 12:19 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34322: Correct icon triggering more fund search options (1.70 KB, patch)
2023-07-20 12:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34322: Correct icon triggering more fund search options (1.74 KB, patch)
2023-07-20 15:54 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34322: Correct icon triggering more fund search options (1.80 KB, patch)
2023-07-29 17:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-20 12:15:56 UTC
On budget and fund pages the search header form has a folder icon which triggers the expansion of the library filter. On other pages we use "fa-sliders" to indicate that there are more search options.
Comment 1 Owen Leonard 2023-07-20 12:54:45 UTC
Created attachment 153719 [details] [review]
Bug 34322: Correct icon triggering more fund search options

This patch updates the budget/fund administration header search form so
that it uses the "fa-slider" Font Awesome icon instead of a folder icon.
This makes it consistent with other search forms which have a similar
set of additional options.

To test, apply the patch and go to Administration -> Budgets.

- The "Search funds" form should have the "fa-sliders" icon.
- Clicking it should trigger the expansion of the additional search
  options.
Comment 2 Sam Lau 2023-07-20 15:54:05 UTC
Created attachment 153733 [details] [review]
Bug 34322: Correct icon triggering more fund search options

This patch updates the budget/fund administration header search form so
that it uses the "fa-slider" Font Awesome icon instead of a folder icon.
This makes it consistent with other search forms which have a similar
set of additional options.

To test, apply the patch and go to Administration -> Budgets.

- The "Search funds" form should have the "fa-sliders" icon.
- Clicking it should trigger the expansion of the additional search
  options.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-07-29 17:30:17 UTC
Created attachment 154055 [details] [review]
Bug 34322: Correct icon triggering more fund search options

This patch updates the budget/fund administration header search form so
that it uses the "fa-slider" Font Awesome icon instead of a folder icon.
This makes it consistent with other search forms which have a similar
set of additional options.

To test, apply the patch and go to Administration -> Budgets.

- The "Search funds" form should have the "fa-sliders" icon.
- Clicking it should trigger the expansion of the additional search
  options.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-15 09:14:07 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-17 19:55:57 UTC
Depends on Bug 32910 not in 23.05.x