Bug 34328 - Add Scottish Gaelic to the advanced search options
Summary: Add Scottish Gaelic to the advanced search options
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-20 15:07 UTC by Martin Renvoize
Modified: 2023-12-27 15:27 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06


Attachments
Bug 34328: Add Scottish Gaelic to languages (3.66 KB, patch)
2023-07-20 15:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34328: Add Scottish Gaelic to languages (3.76 KB, patch)
2023-07-21 06:52 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34328: (follow-up) Add description to en_GB (1.84 KB, patch)
2023-07-21 07:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34328: Add Scottish Gaelic to languages (3.72 KB, patch)
2023-10-06 09:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34328: (follow-up) Add description to en_GB (1.84 KB, patch)
2023-10-06 09:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34328: Make update idempotent (2.99 KB, patch)
2023-10-06 09:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34328: Add Scottish Gaelic to languages (3.78 KB, patch)
2023-11-04 12:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34328: (follow-up) Add description to en_GB (1.89 KB, patch)
2023-11-04 12:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34328: Make update idempotent (3.65 KB, patch)
2023-11-04 12:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-07-20 15:07:12 UTC
For languages to appear in the advanced search options they must appear in the language_rfc4646_to_iso639 table.

Scottish Gaelic is missing, iso639 code gd and rfc4646 code gla.
Comment 1 Martin Renvoize 2023-07-20 15:32:26 UTC
Created attachment 153728 [details] [review]
Bug 34328: Add Scottish Gaelic to languages
Comment 2 Marcel de Rooy 2023-07-21 06:52:46 UTC
Created attachment 153754 [details] [review]
Bug 34328: Add Scottish Gaelic to languages

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-07-21 06:53:05 UTC
 WARN   installer/data/mysql/atomicupdate/bug_34328.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0, now: 14)
Comment 4 Marcel de Rooy 2023-07-21 06:53:59 UTC
Not seeing special handling for UTF-8 here, but it looks like it is interpreted right by the file slurping of atomicupdate.
Comment 5 Martin Renvoize 2023-07-21 07:22:42 UTC
Created attachment 153755 [details] [review]
Bug 34328: (follow-up) Add description to en_GB

This follow-up adds the language description string for Scottish Gaelic
to the en_GB translation.
Comment 6 Martin Renvoize 2023-07-21 07:25:04 UTC
Thanks for the signoff Marcel.. I must admit this area of Koha is a little new to me, an area I've really not dug deep in so far.. 

I've added a follow-up after our customer reported they still couldn't see the language in the search dropdowns and we traced it back to them running the en-GB translated interface.

Is it just me, or is this a rather unmaintainable approach to this?  I feel like the options in these tables are rather out of date compared to the translations we list in Pootle.. shouldn't we effectively have one description per language in pootle per language MARC supports.. ?
Comment 7 Marcel de Rooy 2023-07-21 07:27:48 UTC
Katrin should know it best. And she is in cc.

I agree that this is laborious.
Comment 8 Jonathan Druart 2023-09-01 12:15:23 UTC
Not idempotent

ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'gd-gla' for key 'uniq_code' at /kohadevbox/koha/C4/Installer.pm line 741
Comment 9 Martin Renvoize 2023-10-06 09:42:29 UTC
Created attachment 156593 [details] [review]
Bug 34328: Add Scottish Gaelic to languages

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Martin Renvoize 2023-10-06 09:42:32 UTC
Created attachment 156594 [details] [review]
Bug 34328: (follow-up) Add description to en_GB

This follow-up adds the language description string for Scottish Gaelic
to the en_GB translation.
Comment 11 Martin Renvoize 2023-10-06 09:42:34 UTC
Created attachment 156595 [details] [review]
Bug 34328: Make update idempotent
Comment 12 Katrin Fischer 2023-11-04 12:01:20 UTC
Thank you for including the German translation! :)
Comment 13 Katrin Fischer 2023-11-04 12:02:22 UTC
Created attachment 158371 [details] [review]
Bug 34328: Add Scottish Gaelic to languages

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2023-11-04 12:02:25 UTC
Created attachment 158372 [details] [review]
Bug 34328: (follow-up) Add description to en_GB

This follow-up adds the language description string for Scottish Gaelic
to the en_GB translation.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Katrin Fischer 2023-11-04 12:02:28 UTC
Created attachment 158373 [details] [review]
Bug 34328: Make update idempotent

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Perltidied the atomic update.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Tomás Cohen Arazi 2023-11-08 20:42:41 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Fridolin Somers 2023-11-11 01:23:42 UTC
For reference, you can find this language definitions gla/gd in :
https://www.loc.gov/standards/iso639-2/php/code_list.php
Comment 18 Fridolin Somers 2023-11-11 01:27:34 UTC
Small enhancement, I choose to backport.

Pushed to 23.05.x for 23.05.06
Comment 19 Aude Charillon 2023-12-27 15:27:06 UTC
No changes to the Koha Manual needed.