Bug 34341 - Revert Bug 34072: Holds queue search interface hidden on small screens
Summary: Revert Bug 34072: Holds queue search interface hidden on small screens
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 34072
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-21 13:55 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens (1.68 KB, patch)
2023-08-18 12:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens (1.73 KB, patch)
2023-08-18 13:34 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens (1.79 KB, patch)
2023-08-24 21:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-21 13:55:47 UTC
I am not able to reproduce Bug 34072 in Koha before the patch. In my test, the holds queue sidebar filter doesn't disappear, it just gets moved down to below the holds queue table when the browser window is below a certain width. This is to be expected with anything in the sidebar.

I think the should be reverted. It has unwanted side-effects (changing margins around fieldsets and submit buttons) and doesn't seem to fix any bug as far as I can tell.
Comment 1 Owen Leonard 2023-08-18 12:20:41 UTC
Created attachment 154651 [details] [review]
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens

This patch undoes the changes made by 34072 because they have had a more
far-reaching effect than was expected. I have never been able to
reproduce Bug 34072 before the patch.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Circulation -> Holds queue
- Try adjusting the width of the browser window to confirm that it is
  responsive at various widths.
- When the viewport width is below 768 the page layout will adjust, and
  the contents of the sidebar will drop below the table of holds. This
  is consistent with other pages in the staff interface.
- Check that the corrected CSS has resulted in a correction to the
  layout of submit buttons in forms:
  - For example, in Administration -> Cities and towns -> New city.
  - Before the patch there was no padding between the submit button and
    the white fieldset containing the form fields.
  - After the patch the correct padding has been restored.
Comment 2 Lucas Gass 2023-08-18 13:34:08 UTC
Created attachment 154655 [details] [review]
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens

This patch undoes the changes made by 34072 because they have had a more
far-reaching effect than was expected. I have never been able to
reproduce Bug 34072 before the patch.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Circulation -> Holds queue
- Try adjusting the width of the browser window to confirm that it is
  responsive at various widths.
- When the viewport width is below 768 the page layout will adjust, and
  the contents of the sidebar will drop below the table of holds. This
  is consistent with other pages in the staff interface.
- Check that the corrected CSS has resulted in a correction to the
  layout of submit buttons in forms:
  - For example, in Administration -> Cities and towns -> New city.
  - Before the patch there was no padding between the submit button and
    the white fieldset containing the form fields.
  - After the patch the correct padding has been restored.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-08-24 21:10:20 UTC
Created attachment 154754 [details] [review]
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens

This patch undoes the changes made by 34072 because they have had a more
far-reaching effect than was expected. I have never been able to
reproduce Bug 34072 before the patch.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Circulation -> Holds queue
- Try adjusting the width of the browser window to confirm that it is
  responsive at various widths.
- When the viewport width is below 768 the page layout will adjust, and
  the contents of the sidebar will drop below the table of holds. This
  is consistent with other pages in the staff interface.
- Check that the corrected CSS has resulted in a correction to the
  layout of submit buttons in forms:
  - For example, in Administration -> Cities and towns -> New city.
  - Before the patch there was no padding between the submit button and
    the white fieldset containing the form fields.
  - After the patch the correct padding has been restored.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-29 17:36:29 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-30 06:48:20 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-08-31 10:12:09 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x