In some places, 'fines' is plural and in other places, it is singular. There might be a reason a native English speaker could explain. Plural "Circulation and fines rules" - Administration page - Administration menu bar on the left Singular "Circulation and fine rules" - Circulation and fine rules page title tag - Circulation and fine rules page breadcrumbs - Circulation and fine rules page header ("Defining circulation and fine rules") - Everywhere else on that page... Singular seems to be used more, should we change the administration page and administration menu? Feel free to close if this is normal and I'm making a mountain out of a molehill :)
Created attachment 153836 [details] [review] Bug 34345: 'Circulation and fine rules' vs 'Circulation and fines rules' This patch corrects two instances of the phrase "Circulation and fines rules" in favor of the more common "Circulation and fine rules" for consistency's sake. To test, apply the patch and go to Administration. - In the description under the "Circulation and fine rules" link it should read, "Define circulation and fine rules..." - Open the Circulation and fine rules page and confirm that the link in the sidebar menu is correct.
Created attachment 153933 [details] [review] Bug 34345: 'Circulation and fine rules' vs 'Circulation and fines rules' This patch corrects two instances of the phrase "Circulation and fines rules" in favor of the more common "Circulation and fine rules" for consistency's sake. To test, apply the patch and go to Administration. - In the description under the "Circulation and fine rules" link it should read, "Define circulation and fine rules..." - Open the Circulation and fine rules page and confirm that the link in the sidebar menu is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Owen!
Created attachment 154112 [details] [review] Bug 34345: 'Circulation and fine rules' vs 'Circulation and fines rules' This patch corrects two instances of the phrase "Circulation and fines rules" in favor of the more common "Circulation and fine rules" for consistency's sake. To test, apply the patch and go to Administration. - In the description under the "Circulation and fine rules" link it should read, "Define circulation and fine rules..." - Open the Circulation and fine rules page and confirm that the link in the sidebar menu is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 154113 [details] [review] Bug 34345: (QA follow-up) Fix some more occurrences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x