Bug 34351 - ILL list table - access_url column content should be clickable
Summary: ILL list table - access_url column content should be clickable
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Pedro Amorim
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-24 10:23 UTC by Pedro Amorim
Modified: 2023-11-29 10:56 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34351: Add link to access_url (1.37 KB, patch)
2023-07-24 10:24 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34351: Add link to access_url (1.43 KB, patch)
2023-07-24 16:07 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34351: Add link to access_url (1.49 KB, patch)
2023-07-31 20:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-07-24 10:23:05 UTC

    
Comment 1 Pedro Amorim 2023-07-24 10:24:03 UTC
Created attachment 153832 [details] [review]
Bug 34351: Add link to access_url

On k-t-d
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Create a new Freeform request
3) Update access_url field. Run this mysql query:
update illrequests set accessurl = https://koha-community.org/;
4) Visit ill table list at /cgi-bin/koha/ill/ill-requests.pl
5) Verify access url is not clickable
6) Apply patch. Refresh. Verify it's now clickable.
Comment 2 Pedro Amorim 2023-07-24 16:07:33 UTC
Created attachment 153848 [details] [review]
Bug 34351: Add link to access_url

On k-t-d
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Create a new Freeform request
3) Update access_url field. Run this mysql query:
update illrequests set accessurl = https://koha-community.org/;
4) Visit ill table list at /cgi-bin/koha/ill/ill-requests.pl
5) Verify access url is not clickable
6) Apply patch. Refresh. Verify it's now clickable.

Signed-off by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Comment 3 Katrin Fischer 2023-07-31 20:29:50 UTC
Created attachment 154115 [details] [review]
Bug 34351: Add link to access_url

On k-t-d
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Create a new Freeform request
3) Update access_url field. Run this mysql query:
update illrequests set accessurl = https://koha-community.org/;
4) Visit ill table list at /cgi-bin/koha/ill/ill-requests.pl
5) Verify access url is not clickable
6) Apply patch. Refresh. Verify it's now clickable.

Signed-off by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-15 12:20:17 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-17 20:25:09 UTC
Enhancement not pushed to 23.05.x