If the syspref RecordStaffUserOnCheckout is enabled, a new column is added patron checkout history to show the staff member who checked the item out to the patron. When enabled, the default sort moves from 'Date Due' to 'Checked out by' which isn't useful. To replicate: - Check out an item to a patron - View checkout history, default sort is on 'Date due' - Enable RecordStaffUserOnCheckout - View checkout history, default sort is on 'Checked out by' Bug 28891 addressed a similar issue in the past but it seems to be a problem again.
Created attachment 154571 [details] [review] Bug 34356: Make sort order always default to correct column To test: 1- Check out an item to a patron 2- View checkout history, default sort is on 'Date due' 3- Enable RecordStaffUserOnCheckout 4- View checkout history, default sort is on 'Checked out by' 5- Apply patch 6- Table should sort to 'Date due' no matter what the sys pref is set to
Created attachment 154572 [details] [review] Bug 34356: Make sort order always default to correct column To test: 1- Check out an item to a patron 2- View checkout history, default sort is on 'Date due' 3- Enable RecordStaffUserOnCheckout 4- View checkout history, default sort is on 'Checked out by' 5- Apply patch 6- Table should sort to 'Date due' no matter what the sys pref is set to Signed-off-by: Jason <jrobb@sekls.org>
Fix worked for me, thanks!
Created attachment 154805 [details] [review] Bug 34356: Make sort order always default to correct column To test: 1- Check out an item to a patron 2- View checkout history, default sort is on 'Date due' 3- Enable RecordStaffUserOnCheckout 4- View checkout history, default sort is on 'Checked out by' 5- Apply patch 6- Table should sort to 'Date due' no matter what the sys pref is set to Signed-off-by: Jason <jrobb@sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x