To recreate: 1. From the patron Accounting tab > "Create manual credit" 2. After doing so visit accountline-details.pl for that particular transaction. 3. Notice that there is no related transaction information. 4. It would be nice if this displayed, especially the managing Librarian bit.
My mistake. Where the managing librarian is needed is in the Details of debit/credit table.
Created attachment 155345 [details] [review] Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit.
You construct the name display here manually.. don't we have an include for that to ensure consistency?
Created attachment 155379 [details] [review] Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 155380 [details] [review] Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method.
I signed off and added a follow-up to convert to using the aforementioned include. I'm confused by that include.. it requires `hide_patron_infos_if_needed => 1` is passed to allow a link to be created. In this case, we're looking at a librarian, I sort of feel like we should be able to override the hide but that would nuke the link which would be a regression I believe. Anywho.. it's looking good to me now.
(In reply to Martin Renvoize from comment #6) > I signed off and added a follow-up to convert to using the aforementioned > include. > > I'm confused by that include.. it requires `hide_patron_infos_if_needed => > 1` is passed to allow a link to be created. In this case, we're looking at a > librarian, I sort of feel like we should be able to override the hide but > that would nuke the link which would be a regression I believe. > > Anywho.. it's looking good to me now. Thank you, Martin!
Created attachment 157234 [details] [review] Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 157235 [details] [review] Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Tiny rebase.. deciding to upgrade my SO to a PQA as the patch is trivial, clear and QA scripts are happy.
Thank you, Martin!
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x