Bug 34379 - Inconsistencies in Library groups page
Summary: Inconsistencies in Library groups page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 16:30 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34379: Fix label of new library group button (1.42 KB, patch)
2023-08-18 08:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34379: Fix label of new library group button (1.47 KB, patch)
2023-08-18 09:10 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 34379: Fix label of new library group button (1.53 KB, patch)
2023-08-24 21:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 16:30:20 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Libraries page, here is what should be changed to make it consistent with the other pages in the module:

- Change the 'Add group' button to 'New group'
Comment 1 Caroline Cyr La Rose 2023-07-25 16:30:59 UTC
(In reply to Caroline Cyr La Rose from comment #0)
> While testing bug 33909, I had to look at all the pages in the
> administration module. In doing so, I found some inconsistencies between the
> various pages. 
> 
> For the Libraries page, here is what should be changed to make it consistent
> with the other pages in the module:
> 
> - Change the 'Add group' button to 'New group'

I meant the Library groups page...
Comment 2 Owen Leonard 2023-08-18 08:54:41 UTC
Created attachment 154607 [details] [review]
Bug 34379: Fix label of new library group button

This patch corrects the label on the button for creating a new library
group, changing it from "Add group" to "New group" for consistency.

To test, apply the patch and go to Administration -> Library groups.
Confirm that the button is now labeled "New group" and that it
still works to trigger the library group creation modal.
Comment 3 PTFS Europe Sandboxes 2023-08-18 09:10:16 UTC
Created attachment 154621 [details] [review]
Bug 34379: Fix label of new library group button

This patch corrects the label on the button for creating a new library
group, changing it from "Add group" to "New group" for consistency.

To test, apply the patch and go to Administration -> Library groups.
Confirm that the button is now labeled "New group" and that it
still works to trigger the library group creation modal.

Signed-off-by: Andrew <andrew.auld@ptfs-europe.com>
Comment 4 Andrew Auld 2023-08-18 09:10:45 UTC
Yay! Quick and easy to sign-off...just the ticket. :)
Comment 5 Katrin Fischer 2023-08-24 21:25:59 UTC
Created attachment 154758 [details] [review]
Bug 34379: Fix label of new library group button

This patch corrects the label on the button for creating a new library
group, changing it from "Add group" to "New group" for consistency.

To test, apply the patch and go to Administration -> Library groups.
Confirm that the button is now labeled "New group" and that it
still works to trigger the library group creation modal.

Signed-off-by: Andrew <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-08-29 17:58:22 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-08-30 07:00:18 UTC
Pushed to 23.05.x for 23.05.04
Comment 8 Matt Blenkinsop 2023-08-31 10:24:22 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x