While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Libraries page, here is what should be changed to make it consistent with the other pages in the module: - Change the 'Add group' button to 'New group'
(In reply to Caroline Cyr La Rose from comment #0) > While testing bug 33909, I had to look at all the pages in the > administration module. In doing so, I found some inconsistencies between the > various pages. > > For the Libraries page, here is what should be changed to make it consistent > with the other pages in the module: > > - Change the 'Add group' button to 'New group' I meant the Library groups page...
Created attachment 154607 [details] [review] Bug 34379: Fix label of new library group button This patch corrects the label on the button for creating a new library group, changing it from "Add group" to "New group" for consistency. To test, apply the patch and go to Administration -> Library groups. Confirm that the button is now labeled "New group" and that it still works to trigger the library group creation modal.
Created attachment 154621 [details] [review] Bug 34379: Fix label of new library group button This patch corrects the label on the button for creating a new library group, changing it from "Add group" to "New group" for consistency. To test, apply the patch and go to Administration -> Library groups. Confirm that the button is now labeled "New group" and that it still works to trigger the library group creation modal. Signed-off-by: Andrew <andrew.auld@ptfs-europe.com>
Yay! Quick and easy to sign-off...just the ticket. :)
Created attachment 154758 [details] [review] Bug 34379: Fix label of new library group button This patch corrects the label on the button for creating a new library group, changing it from "Add group" to "New group" for consistency. To test, apply the patch and go to Administration -> Library groups. Confirm that the button is now labeled "New group" and that it still works to trigger the library group creation modal. Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x