Bug 34380 - Inconsistencies in Item types page titles, breadcrumbs, and header
Summary: Inconsistencies in Item types page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 16:33 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:20 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header (3.79 KB, patch)
2023-09-05 17:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header (3.98 KB, patch)
2023-09-08 11:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header (4.14 KB, patch)
2023-09-11 14:30 UTC, Emily-Rose Francoeur
Details | Diff | Splinter Review
Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header (4.19 KB, patch)
2023-09-17 12:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 16:33:09 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Item types page, here is what should be changed to make it consistent with the other pages in the module:


Page title
- Change 'Add item type' in page title to 'New item type'
- Change "Delete item type 'Y'?" to "Confirm deletion of item type 'Y'" in page title

Breadcrumb
- Change 'Item types administration' in breadcrumb to 'Item types'
- Change 'Add item type' in breadcrumb to 'New item type'
- Change "Delete item type 'Y'?" to "Confirm deletion of item type 'Y'" in breadcrumb

Page header
- Change 'Item types administration' in page header to 'Item types'
- Change 'Add item type' in page header to 'New item type'
- Add item type code to Modify X in page header
- Change "Delete item type 'Y'?" to "Are you sure you want to delete item type 'Y'" in page header
Comment 1 Caroline Cyr La Rose 2023-07-26 17:05:09 UTC
 
> Breadcrumb
> - Change 'Item types administration' in breadcrumb to 'Item types'
> 
> Page header
> - Change 'Item types administration' in page header to 'Item types'

These two points are corrected in bug 34344.
Comment 2 Owen Leonard 2023-09-05 17:10:33 UTC Comment hidden (obsolete)
Comment 3 David Cook 2023-09-06 02:36:48 UTC
I think this patch creates an inconsistency on http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form where the title and breadcrumbs are saying "New item type" but the <h1> header is still saying "Add item type".

--

I also noticed when I tried to delete the item type "Books" that it just says:

"Cannot delete this item type.
This record is in use. Deletion is not possible."

That differs from the deletion message you see when you try to delete "Computer Files", which asks "Are you sure you want to delete item type 'CF'?" which is one of the updated deletion messages.
Comment 4 Owen Leonard 2023-09-08 11:24:52 UTC
Created attachment 155405 [details] [review]
Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header

This patch fixes inconsistencies in the item type administration page so
that page titles, breadcrumb navigation, and page headers are consistent
with each other and with other pages in Koha.

To test, apply the patch and go to Administration -> Item types. Check
each variation of the page to confirm that everything looks correct:

- Item types list
 - New item type
 - Edit item type
 - Confirm deletion of item type
Comment 5 Owen Leonard 2023-09-08 11:28:37 UTC
(In reply to David Cook from comment #3)
> "Cannot delete this item type.
> This record is in use. Deletion is not possible."

This message is displayed when the item type is in use.
 
> That differs from the deletion message you see when you try to delete
> "Computer Files", which asks "Are you sure you want to delete item type
> 'CF'?"

This message is different because it's asking for confirmation before deleting an item type which is not in use. I think the differences in these messages is to be expected.
Comment 6 Emily-Rose Francoeur 2023-09-11 14:30:51 UTC
Created attachment 155496 [details] [review]
Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header

This patch fixes inconsistencies in the item type administration page so
that page titles, breadcrumb navigation, and page headers are consistent
with each other and with other pages in Koha.

To test, apply the patch and go to Administration -> Item types. Check
each variation of the page to confirm that everything looks correct:

- Item types list
 - New item type
 - Edit item type
 - Confirm deletion of item type

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 7 Katrin Fischer 2023-09-17 12:51:04 UTC
Created attachment 155742 [details] [review]
Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header

This patch fixes inconsistencies in the item type administration page so
that page titles, breadcrumb navigation, and page headers are consistent
with each other and with other pages in Koha.

To test, apply the patch and go to Administration -> Item types. Check
each variation of the page to confirm that everything looks correct:

- Item types list
 - New item type
 - Edit item type
 - Confirm deletion of item type

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-09-18 15:03:54 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-09-18 20:07:39 UTC
Like others, not pushed to 23.05.x