Bug 34384 - Inconsistencies in Library transfer limits page titles, breadcrumbs, and header
Summary: Inconsistencies in Library transfer limits page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 33909
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 16:58 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:50 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading (4.12 KB, patch)
2023-08-18 11:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading (4.17 KB, patch)
2023-08-18 14:16 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading (4.23 KB, patch)
2023-08-24 22:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 16:58:35 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Library transfer limits page (basic editor), here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Library checkin and transfer policy' to 'Library transfer limits'
- Should the branchcode be there? (e.g. Library transfer limits for 'CPL')

Breadcrumb
- Change 'Set library checkin and transfer policy' to 'Library transfer limits'
- Should the branchcode be there? (e.g. Library transfer limits for 'CPL')

Page header
- Change 'Library CPL - Centerville Checkin and transfer policy' to "Library transfer limits for 'CPL'"


For the advanced editor,

Page title
- Change 'Library checkin and transfer policy' to 'Library transfer limits'

Breadcrumb
- Change 'Set library checkin and transfer policy' to 'Library transfer limits'

Page header
- Change 'Checkin and transfer policy' to 'Library transfer limits'
Comment 1 Owen Leonard 2023-08-18 11:25:17 UTC
Created attachment 154640 [details] [review]
Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading

This patch makes a few minor corrections to the library transfer limits
pages, both basic and advanced, standardizing on the name "Library
transfer limits" for page title, breadcrumb navigation, and page
heading.

To test, apply the patch and go to Administration -> Library transfer
limits.

- Confirm that the page shows "Library transfer limits for [library]
  [library code]"
- Breadcrumb navigation, page title, and heading should match.
- Swith to the advanced editor
- The title should now be simply "Library transfer limits"
Comment 2 Lucas Gass 2023-08-18 14:16:46 UTC
Created attachment 154659 [details] [review]
Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading

This patch makes a few minor corrections to the library transfer limits
pages, both basic and advanced, standardizing on the name "Library
transfer limits" for page title, breadcrumb navigation, and page
heading.

To test, apply the patch and go to Administration -> Library transfer
limits.

- Confirm that the page shows "Library transfer limits for [library]
  [library code]"
- Breadcrumb navigation, page title, and heading should match.
- Swith to the advanced editor
- The title should now be simply "Library transfer limits"

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-08-24 22:34:00 UTC
Created attachment 154763 [details] [review]
Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading

This patch makes a few minor corrections to the library transfer limits
pages, both basic and advanced, standardizing on the name "Library
transfer limits" for page title, breadcrumb navigation, and page
heading.

To test, apply the patch and go to Administration -> Library transfer
limits.

- Confirm that the page shows "Library transfer limits for [library]
  [library code]"
- Breadcrumb navigation, page title, and heading should match.
- Swith to the advanced editor
- The title should now be simply "Library transfer limits"

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-29 17:58:33 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-30 07:06:14 UTC
Does not apply on 23.05.x, maybe depends on Bug 33909 ?