While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Cities and towns page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add city name, in single quotes, to Modify X (e.g. Modify city 'Montreal') - Add city name, in single quotes, to Confirm deletion of X (e.g. Confirm deletion of city 'Montreal') Breadcrumb - Add city name, in single quotes, to Modify X (e.g. Modify city 'Montreal') - Add city name, in single quotes, to Confirm deletion of X (e.g. Confirm deletion of city 'Montreal') Page header - Change 'Modify a city' to "Modify city 'Y'" (as above) - Change "Delete city 'Y?'" to "Confirm deletion of city 'Y'"
Created attachment 154645 [details] [review] Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header This patch updates the cities administration page so that page title, breadcrumb navigation, and headings are consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Cities and towns. Check each variation of the page to confirm that page title, breadcrumb navigation, and heading are correct. - Main page (listing cities) - New city - Edit city - Delete city
Created attachment 154657 [details] [review] Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header This patch updates the cities administration page so that page title, breadcrumb navigation, and headings are consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Cities and towns. Check each variation of the page to confirm that page title, breadcrumb navigation, and heading are correct. - Main page (listing cities) - New city - Edit city - Delete city Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 154761 [details] [review] Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header This patch updates the cities administration page so that page title, breadcrumb navigation, and headings are consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Cities and towns. Check each variation of the page to confirm that page title, breadcrumb navigation, and heading are correct. - Main page (listing cities) - New city - Edit city - Delete city Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x