Bug 34386 - Inconsistencies in Cities and towns page titles, breadcrumbs, and header
Summary: Inconsistencies in Cities and towns page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 17:05 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header (3.01 KB, patch)
2023-08-18 12:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header (3.06 KB, patch)
2023-08-18 14:11 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header (3.12 KB, patch)
2023-08-24 21:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 17:05:07 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Cities and towns page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add city name, in single quotes, to Modify X (e.g. Modify city 'Montreal')
- Add city name, in single quotes, to Confirm deletion of X (e.g. Confirm deletion of city 'Montreal')

Breadcrumb
- Add city name, in single quotes, to Modify X (e.g. Modify city 'Montreal')
- Add city name, in single quotes, to Confirm deletion of X (e.g. Confirm deletion of city 'Montreal')

Page header
- Change 'Modify a city' to "Modify city 'Y'" (as above)
- Change "Delete city 'Y?'" to "Confirm deletion of city 'Y'"
Comment 1 Owen Leonard 2023-08-18 12:01:19 UTC
Created attachment 154645 [details] [review]
Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header

This patch updates the cities administration page so that page title,
breadcrumb navigation, and headings are consistent with each other and
with other parts of Koha.

To test, apply the patch and go to Administration -> Cities and towns.
Check each variation of the page to confirm that page title, breadcrumb
navigation, and heading are correct.

- Main page (listing cities)
- New city
- Edit city
- Delete city
Comment 2 Lucas Gass 2023-08-18 14:11:09 UTC
Created attachment 154657 [details] [review]
Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header

This patch updates the cities administration page so that page title,
breadcrumb navigation, and headings are consistent with each other and
with other parts of Koha.

To test, apply the patch and go to Administration -> Cities and towns.
Check each variation of the page to confirm that page title, breadcrumb
navigation, and heading are correct.

- Main page (listing cities)
- New city
- Edit city
- Delete city

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-08-24 21:40:38 UTC
Created attachment 154761 [details] [review]
Bug 34386: Fix inconsistencies in Cities and tows page titles, breadcrumbs, and header

This patch updates the cities administration page so that page title,
breadcrumb navigation, and headings are consistent with each other and
with other parts of Koha.

To test, apply the patch and go to Administration -> Cities and towns.
Check each variation of the page to confirm that page title, breadcrumb
navigation, and heading are correct.

- Main page (listing cities)
- New city
- Edit city
- Delete city

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-29 17:58:40 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-30 07:05:30 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-08-31 10:24:28 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x