Bug 34388 - Inconsistencies in Patron restriction types page headers
Summary: Inconsistencies in Patron restriction types page headers
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 18:13 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:21 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34388: Fix inconsistencies in Patron restriction types page headers (3.69 KB, patch)
2023-08-21 15:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34388: Fix inconsistencies in Patron restriction types page headers (3.76 KB, patch)
2023-08-29 16:15 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34388: Fix inconsistencies in Patron restriction types page headers (3.85 KB, patch)
2023-09-01 07:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 18:13:42 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Patron restriction types page, here is what should be changed to make it consistent with the other pages in the module:

Page header
- Add single quotes around the type name in Modify X

The styling of the page Confirm deletion of X is inconsistent with other pages of the same type. It is usually presented as a warning (yellow background) and the buttons are 'Yes, delete X' and 'No, don't delete'.
Comment 1 Owen Leonard 2023-08-21 15:20:17 UTC
Created attachment 154682 [details] [review]
Bug 34388: Fix inconsistencies in Patron restriction types page headers

This patch fixes a couple of inconsistencies in the style of the patron
restriction types administration screen, making sure the restriction
type name is consistently in single quotes in headings and formatting
the deletion confirmation page like other administration interfaces.

Note: This patch contains indentation spaces, so ignore whitespace when
viewing the diff.

To test, apply the patch and go to Administration -> Patron restriction
types.

- If necessary, add a custom restriction type.
- After saving it, edit it.
- The page title, breadcrumb, and page heading should match: "Modify
  restriction type 'X'

- From the list of restriction types, click "Delete" on one of your
  custom restriction types.
- On the deletion confirmation page you should see a standard
  alert-style dialog box and two button options: "Yes, delete" and "No,
  do not delete." Both should work correctly.
Comment 2 Caroline Cyr La Rose 2023-08-29 16:15:11 UTC
Created attachment 154908 [details] [review]
Bug 34388: Fix inconsistencies in Patron restriction types page headers

This patch fixes a couple of inconsistencies in the style of the patron
restriction types administration screen, making sure the restriction
type name is consistently in single quotes in headings and formatting
the deletion confirmation page like other administration interfaces.

Note: This patch contains indentation spaces, so ignore whitespace when
viewing the diff.

To test, apply the patch and go to Administration -> Patron restriction
types.

- If necessary, add a custom restriction type.
- After saving it, edit it.
- The page title, breadcrumb, and page heading should match: "Modify
  restriction type 'X'

- From the list of restriction types, click "Delete" on one of your
  custom restriction types.
- On the deletion confirmation page you should see a standard
  alert-style dialog box and two button options: "Yes, delete" and "No,
  do not delete." Both should work correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Marcel de Rooy 2023-09-01 07:49:08 UTC
Created attachment 155055 [details] [review]
Bug 34388: Fix inconsistencies in Patron restriction types page headers

This patch fixes a couple of inconsistencies in the style of the patron
restriction types administration screen, making sure the restriction
type name is consistently in single quotes in headings and formatting
the deletion confirmation page like other administration interfaces.

Note: This patch contains indentation spaces, so ignore whitespace when
viewing the diff.

To test, apply the patch and go to Administration -> Patron restriction
types.

- If necessary, add a custom restriction type.
- After saving it, edit it.
- The page title, breadcrumb, and page heading should match: "Modify
  restriction type 'X'

- From the list of restriction types, click "Delete" on one of your
  custom restriction types.
- On the deletion confirmation page you should see a standard
  alert-style dialog box and two button options: "Yes, delete" and "No,
  do not delete." Both should work correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2023-09-01 14:10:36 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-08 00:44:13 UTC
Like Bug 33909, I prefer not to backport