Bug 34389 - Inconsistencies in Debit types page titles, breadcrumbs, and header
Summary: Inconsistencies in Debit types page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 18:16 UTC by Caroline Cyr La Rose
Modified: 2023-10-14 12:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other.
Version(s) released in:
23.11.00


Attachments
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header (2.57 KB, patch)
2023-10-02 15:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header (2.62 KB, patch)
2023-10-02 23:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header (2.68 KB, patch)
2023-10-03 09:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 18:16:09 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Debit types page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add debit type code to Modify X (e.g. Modify debit type 'MANUAL')

Breadcrumb
- Add debit type code to Modify X (e.g. Modify debit type 'MANUAL')

Page header
- Change 'Modify a debit type' to "Modify debit type 'Y'"
Comment 1 Owen Leonard 2023-10-02 15:50:24 UTC
Created attachment 156457 [details] [review]
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the debit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Debit types. Test
each variation of the page:

- Main page
- New debit type
- Modify debit type
Comment 2 David Nind 2023-10-02 23:39:53 UTC
Created attachment 156465 [details] [review]
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the debit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Debit types. Test
each variation of the page:

- Main page
- New debit type
- Modify debit type

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-10-03 09:58:07 UTC
Created attachment 156484 [details] [review]
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the debit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Debit types. Test
each variation of the page:

- Main page
- New debit type
- Modify debit type

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-10-03 13:18:49 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-05 19:27:28 UTC
Not pushed to 23.05.x