Bug 34391 - Inconsistencies in Cash registers page headers
Summary: Inconsistencies in Cash registers page headers
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 18:21 UTC by Caroline Cyr La Rose
Modified: 2023-10-14 12:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a couple of inconsistencies in the cash register administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other.
Version(s) released in:
23.11.00


Attachments
Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers (4.34 KB, patch)
2023-10-02 16:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers (4.39 KB, patch)
2023-10-02 23:29 UTC, David Nind
Details | Diff | Splinter Review
Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers (4.44 KB, patch)
2023-10-03 09:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 18:21:00 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Cash registers page, here is what should be changed to make it consistent with the other pages in the module:


Page header
- Change 'Add new cash register' to 'New cash register'
- Add cash register ID to page header
Comment 1 Owen Leonard 2023-10-02 16:21:13 UTC
Created attachment 156459 [details] [review]
Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers

Fix inconsistencies in cash register page titles, breadcrumbs, and
header

This patch fixes a couple of inconsistencies in the cash register
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Cash register. Test
each variation of the page:

- Main page
- New cash register
- Modify cash register
Comment 2 David Nind 2023-10-02 23:29:17 UTC
Created attachment 156464 [details] [review]
Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers

Fix inconsistencies in cash register page titles, breadcrumbs, and
header

This patch fixes a couple of inconsistencies in the cash register
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Cash register. Test
each variation of the page:

- Main page
- New cash register
- Modify cash register

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-10-02 23:33:13 UTC
Testing notes (using KTD):

1. Enable UseCashRegisters system preference.

2. I noticed in the patch (I don't normally look at these as I don't know what is going on!), and noticed there was 'stuff' for deleting a cash register. I can't see an option to do this in the staff interface.
Comment 4 Katrin Fischer 2023-10-03 09:58:39 UTC
Created attachment 156485 [details] [review]
Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers

Fix inconsistencies in cash register page titles, breadcrumbs, and
header

This patch fixes a couple of inconsistencies in the cash register
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Cash register. Test
each variation of the page:

- Main page
- New cash register
- Modify cash register

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-10-03 13:18:52 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-05 19:27:08 UTC
Not pushed to 23.05.x