Bug 34394 - Inconsistencies in MARC Bibliographic framework test page title and breadcrumbs
Summary: Inconsistencies in MARC Bibliographic framework test page title and breadcrumbs
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 34396 34635
  Show dependency treegraph
 
Reported: 2023-07-25 18:54 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:21 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs (3.99 KB, patch)
2023-08-25 14:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs (4.06 KB, patch)
2023-08-28 15:08 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs (4.16 KB, patch)
2023-09-01 07:58 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 18:54:10 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the MARC Bibliographic framework test page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change the level to 'MARC bibliographic framework test' (I would remove any mention of success or errors here)

Breadcrumb
- Change the level to 'MARC bibliographic framework test' (I would remove any mention of success or errors here)
Comment 1 Owen Leonard 2023-08-25 14:28:34 UTC
Created attachment 154815 [details] [review]
Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs

This patch makes some changes to the MARC bibliographic framework test
page so that breadcrumbs, page title, and page heading are consistent
with each other.

The patch also creates standard message and alert dialogs to show the
status of the check. This is more consistent than having the message
only at the bottom of the table.

The patch also changes the term "itemnum" to "itemnumber."

To test, apply the patch and go to Admnistration -> MARC bibliographic
framework test.

- The page title, breadcrumb navigation, and page heading should match:
  "MARC bibliographic framework test."
- If your system has no errors, there should be a message-style dialog
  at the top of the page saying "Configuration okay."
- Create an error in your MARC configuration:
  - Go to Administration -> MARC frameworks -> MARC structure
  - Locate the 952 tag and click Actions -> View subfields
  - Edit subfield 9 and set the "Managed in tab" dropdown to something
    other than "ignore"
- Return to the framework test page. There should be an alert-style
  dialog at the top of the page, "Configuration errors found"
Comment 2 Caroline Cyr La Rose 2023-08-28 15:07:54 UTC
Thanks Owen! It's much better now. I wonder if we should remove the "TOTAL" line of the table when there is an error? https://snipboard.io/VXsJ6I.jpg

And also use the singular/plural thing... Not sure what it is called, but the thing that allows to have one string for 1 and one string for more than 1, like "you have 1 error" (singular error) vs "you have 2 errors" (plural errors)?

I'm still singing off because I think it's OK as it is. But I can sign off any follow ups. :)
Comment 3 Caroline Cyr La Rose 2023-08-28 15:08:45 UTC
Created attachment 154887 [details] [review]
Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs

This patch makes some changes to the MARC bibliographic framework test
page so that breadcrumbs, page title, and page heading are consistent
with each other.

The patch also creates standard message and alert dialogs to show the
status of the check. This is more consistent than having the message
only at the bottom of the table.

The patch also changes the term "itemnum" to "itemnumber."

To test, apply the patch and go to Admnistration -> MARC bibliographic
framework test.

- The page title, breadcrumb navigation, and page heading should match:
  "MARC bibliographic framework test."
- If your system has no errors, there should be a message-style dialog
  at the top of the page saying "Configuration okay."
- Create an error in your MARC configuration:
  - Go to Administration -> MARC frameworks -> MARC structure
  - Locate the 952 tag and click Actions -> View subfields
  - Edit subfield 9 and set the "Managed in tab" dropdown to something
    other than "ignore"
- Return to the framework test page. There should be an alert-style
  dialog at the top of the page, "Configuration errors found"

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Marcel de Rooy 2023-09-01 07:58:26 UTC
Created attachment 155059 [details] [review]
Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs

This patch makes some changes to the MARC bibliographic framework test
page so that breadcrumbs, page title, and page heading are consistent
with each other.

The patch also creates standard message and alert dialogs to show the
status of the check. This is more consistent than having the message
only at the bottom of the table.

The patch also changes the term "itemnum" to "itemnumber."

To test, apply the patch and go to Admnistration -> MARC bibliographic
framework test.

- The page title, breadcrumb navigation, and page heading should match:
  "MARC bibliographic framework test."
- If your system has no errors, there should be a message-style dialog
  at the top of the page saying "Configuration okay."
- Create an error in your MARC configuration:
  - Go to Administration -> MARC frameworks -> MARC structure
  - Locate the 952 tag and click Actions -> View subfields
  - Edit subfield 9 and set the "Managed in tab" dropdown to something
    other than "ignore"
- Return to the framework test page. There should be an alert-style
  dialog at the top of the page, "Configuration errors found"

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-09-05 14:53:47 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 06:39:48 UTC
Like others, not backported to 23.05.x