Bug 34395 - Inconsistencies in Authority types page titles, breadcrumbs, and header
Summary: Inconsistencies in Authority types page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 19:26 UTC by Caroline Cyr La Rose
Modified: 2023-10-25 06:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34395: Fix inconsistencies in Authority types page titles, breadcrumbs, and header (19.90 KB, patch)
2023-10-03 16:06 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34395: Fix inconsistencies in Authority types page titles, breadcrumbs, and header (19.97 KB, patch)
2023-10-17 12:56 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 19:26:24 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Authority types page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add authority type code to Modify X in page title (e.g. Modify authority type 'CHRON_TERM')
- Add authority type code to Confirm deletion of authority type
- Add a level with the When viewing the MARC structure of an authority type, with the framework code (e.g. "Authority MARC framework for CHRON_TERM")
- Add the tag number when modifying a tag
- When deleting a tag, change 'Confirm deletion' to "Confirm deletion of tag Y"
- When viewing/editing subfields, add a level for the framework and a level for the tag
- When editing subfields, use 'Modify'


Breadcrumb
- Add authority type code to Modify X in page title (e.g. Modify authority type 'CHRON_TERM')
- Add authority type code to Confirm deletion of authority type
- When viewing the MARC structure of an authority type change the level from "CHRON_TERM Framework" to "Authority MARC framework for CHRON_TERM" (or MARC structure?) 
- Add the tag number when modifying a tag
- When deleting a tag, change 'Confirm deletion' to "Confirm deletion of tag Y"
- When editing subfields, change 'Edit MARC subfields constraints' to "Modify MARC subfields constraints for tag 000"

Page header
- The styling for the header of the New X page is different from the rest<
- The styling for the header of the Modify X page is different from the rest
- Add authority type code to Modify X in page title (e.g. Modify authority type 'CHRON_TERM')
- Add the tag number when modifying a tag
- When deleting a tag, change 'Confirm deletion' to "Confirm deletion of tag Y"
- When viewing subfields, change "Authority MARC subfield structure admin for 035 (authority: CHRON_TERM)" to "Authority MARC subfield structure for tag 035 (CHRON_TERM authority type)" (I'm unsure about how to mention the authority type in the header, but I definitely don't like the colon!)
- When editing subfields, change 'Edit MARC subfields constraints for field 035 authority CHRON_TERM' to "Modify MARC subfields constraints for tag 035 (CHRON_TERM authority type)" (I personally prefer "field" to "tag", but tag is used everywhere else) (I'm also unsure about how to mention the authority type in the header)
Comment 1 Caroline Cyr La Rose 2023-07-25 19:27:21 UTC
This section was pretty big too. I might have gotten some things wrong or forgotten some. Ideally, harmonize with MARC bibliographic frameworks section.
Comment 2 Owen Leonard 2023-10-03 16:06:44 UTC
Created attachment 156507 [details] [review]
Bug 34395: Fix inconsistencies in Authority types page titles, breadcrumbs, and header

This patch fixes some inconsistencies in the authority
types administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Authority types
  - New authority type
  - Edit authority type
  - Delete an authority type which is not used
  - Delete an authority type which is in use
  - Authority type MARC structure
    - New tag
    - Edit tag
    - Delete tag
    - View subfields
    - Edit subfields
Comment 3 Martin Renvoize 2023-10-17 12:56:26 UTC
Created attachment 157244 [details] [review]
Bug 34395: Fix inconsistencies in Authority types page titles, breadcrumbs, and header

This patch fixes some inconsistencies in the authority
types administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Authority types
  - New authority type
  - Edit authority type
  - Delete an authority type which is not used
  - Delete an authority type which is in use
  - Authority type MARC structure
    - New tag
    - Edit tag
    - Delete tag
    - View subfields
    - Edit subfields

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-10-17 12:56:58 UTC
I love consistency improvements!

This looks great, thanks.

Going straight for QA here.. Passed.
Comment 5 Tomás Cohen Arazi 2023-10-17 17:47:55 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-25 06:23:02 UTC
Not pushed to 23.05.x