Bug 34398 - Inconsistencies in Record matching rules page titles, breadcrumbs, and header
Summary: Inconsistencies in Record matching rules page titles, breadcrumbs, and header
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Victor Grousset/tuxayo
URL:
Keywords: Sandbox
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 19:44 UTC by Caroline Cyr La Rose
Modified: 2023-12-14 21:27 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01


Attachments
Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers (12.44 KB, patch)
2023-10-03 17:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers (12.48 KB, patch)
2023-12-03 22:34 UTC, David Nind
Details | Diff | Splinter Review
Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers (12.54 KB, patch)
2023-12-08 21:32 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 34398: (QA follow-up): add missing | (1.96 KB, patch)
2023-12-08 21:32 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 19:44:23 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Record matching rules page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Add record matching rule' to 'New record matching rule'
- Add rule code in single quotes to 'Modify record matching rule'

Breadcrumb
- Change 'Add record matching rule' to 'New record matching rule'
- Add rule code in single quotes to 'Modify record matching rule'

Page header
- Change 'Add record matching rule' to 'New record matching rule'
- Add rule code in single quotes to 'Modify record matching rule'
Comment 1 Owen Leonard 2023-10-03 17:42:06 UTC
Created attachment 156509 [details] [review]
Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the record matching rules
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

Some controls on this page have been updated to use Bootstrap link style
with Font Awesome icons added.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Record matching rules
  - New record matching rule
  - Edit record matching rule
  - Delete record matching rule
  - Test the process of adding new match points and new match checks,
    and removing match points and match checks.
Comment 2 Katy Maydon 2023-11-02 17:33:01 UTC
Testing on 02/11/23:

- Administration -> Record matching rules
  - New record matching rule 
Title - good
Heading - good 
Breadcrumbs - good 

  - Edit record matching rule 
Heading - good
Breadcrumbs - good 

  - Delete record matching rule

Heading - good 
Breadcrumbs - good 

  - Test the process of adding new match points and new match checks,
    and removing match points and match checks.

I don't know if this is an issue, but when you add a new match check or point, remove it and then add another it adds "2" then when you remove 2, it adds "3" instead of another 2, even though you didn't save the original "2".
Comment 3 David Nind 2023-12-03 22:34:22 UTC
Created attachment 159505 [details] [review]
Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the record matching rules
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

Some controls on this page have been updated to use Bootstrap link style
with Font Awesome icons added.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Record matching rules
  - New record matching rule
  - Edit record matching rule
  - Delete record matching rule
  - Test the process of adding new match points and new match checks,
    and removing match points and match checks.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-12-03 22:35:18 UTC
(In reply to Katy Maydon from comment #2)
> Testing on 02/11/23:
> 
...
> I don't know if this is an issue, but when you add a new match check or
> point, remove it and then add another it adds "2" then when you remove 2, it
> adds "3" instead of another 2, even though you didn't save the original "2".

Hi Katy.

It does this before the patch, so I think that would be a separate bug.

David
Comment 5 Victor Grousset/tuxayo 2023-12-08 21:32:46 UTC
Created attachment 159692 [details] [review]
Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the record matching rules
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

Some controls on this page have been updated to use Bootstrap link style
with Font Awesome icons added.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Record matching rules
  - New record matching rule
  - Edit record matching rule
  - Delete record matching rule
  - Test the process of adding new match points and new match checks,
    and removing match points and match checks.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2023-12-08 21:32:48 UTC
Created attachment 159693 [details] [review]
Bug 34398: (QA follow-up): add missing |
Comment 7 Victor Grousset/tuxayo 2023-12-08 21:34:09 UTC
Much cleaner, looks great :)

Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 8 Katrin Fischer 2023-12-11 18:46:45 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2023-12-12 07:51:13 UTC
Pushed to 23.11.x for 23.11.01
Comment 10 Lucas Gass 2023-12-14 21:27:51 UTC
Merge conflicts with 23.05.x, no backport. If needed please rebase.