Bug 34399 - Inconsistencies in Record overlay rules page titles, breadcrumbs, and header
Summary: Inconsistencies in Record overlay rules page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 19:47 UTC by Caroline Cyr La Rose
Modified: 2023-10-25 06:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34399: Fix inconsistencies in Record overlay rules page titles, breadcrumbs, and headers (1.86 KB, patch)
2023-10-03 17:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34399: Fix inconsistencies in Record overlay rules page titles, breadcrumbs, and headers (1.93 KB, patch)
2023-10-17 12:58 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 19:47:27 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Record overlay rules page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'MARC overlay rules' to 'Record overlay rules' (I don't mind either way, but if leaving it as is, then change the admin page and menu link so it matches)

Breadcrumb
- Change 'MARC overlay rules' to 'Record overlay rules' (as above)

Page header
- Change 'Manage MARC overlay rules' to 'Record overlay rules' (remove 'Manage'; as above)
Comment 1 Owen Leonard 2023-10-03 17:56:12 UTC
Created attachment 156510 [details] [review]
Bug 34399: Fix inconsistencies in Record overlay rules page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the record overlay rules
page, making sure the page title, breadcrumb navigation, and page
headers are consistent with each other.

Test the record matching rules page to confirm that page title, heading,
and breadcrumbs are consistent.
Comment 2 Martin Renvoize 2023-10-17 12:58:28 UTC
Created attachment 157245 [details] [review]
Bug 34399: Fix inconsistencies in Record overlay rules page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the record overlay rules
page, making sure the page title, breadcrumb navigation, and page
headers are consistent with each other.

Test the record matching rules page to confirm that page title, heading,
and breadcrumbs are consistent.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2023-10-17 12:58:49 UTC
More consistency improvements.. awesome

Passing QA
Comment 4 Tomás Cohen Arazi 2023-10-17 17:47:59 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-25 06:22:45 UTC
Not pushed to 23.05.x