Bug 34400 - Inconsistencies in OAI sets page titles, breadcrumbs, and header
Summary: Inconsistencies in OAI sets page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 19:54 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:21 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header (6.07 KB, patch)
2023-08-31 18:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header (6.27 KB, patch)
2023-09-06 10:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header (6.43 KB, patch)
2023-09-11 14:14 UTC, Emily-Rose Francoeur
Details | Diff | Splinter Review
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header (6.48 KB, patch)
2023-09-17 13:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 19:54:17 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the OAI sets page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'OAI sets configuration' to 'OAI sets'
- Change 'Add a new OAI set' to 'New OAI set'
- Add a level for when modifying an existing set "Modify OAI set 'code'"
- Change 'OAI set mappings' to "Mappings for set 'name' (code)"

Breadcrumb
- Change 'OAI sets configuration' to 'OAI sets'
- Change 'Add a new OAI set' to 'New OAI set'
- Change "Edit OAI set 'code'" to "Modify OAI set 'code'"
- Change 'OAI set mappings' to "Mappings for set 'name' (code)"


Page header
- Change 'Add a new OAI set' to 'New OAI set'
- Change "Edit OAI set 'code'" to "Modify OAI set 'code'
Comment 1 Owen Leonard 2023-08-31 18:41:43 UTC
Created attachment 155035 [details] [review]
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the style of the
OIA sets administration screen, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The patch also corrects the structure of the form on the OAI set
mappings page so that the submit button is outside the "page-section"
area.

To test, apply the patch and go to Administration -> OAI sets. Test each
variation of the page:

- Main page
- New OAI set
- Edit OAI set
- OAI set mappings
Comment 2 David Cook 2023-09-06 02:25:23 UTC
Comment on attachment 155035 [details] [review]
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header

Review of attachment 155035 [details] [review]:
-----------------------------------------------------------------

Overall, I think it's looking pretty good, but I did note a new inconsistency introduced by this patch.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt
@@ +29,4 @@
>  
>          [% IF ( op_new || op_mod ) %]
>              [% WRAPPER breadcrumb_item %]
> +                <a href="/cgi-bin/koha/admin/oai_sets.pl">OAI sets</a>

This change makes the breadcrumb inconsistent with oai_set_mappings.tt though.

@@ +44,5 @@
>              [% END %]
>  
>          [% ELSE %]
>              [% WRAPPER breadcrumb_item bc_active= 1 %]
> +                <span>OAI sets</span>

This change makes the breadcrumb inconsistent with oai_set_mappings.tt though.
Comment 3 Owen Leonard 2023-09-06 10:45:58 UTC
Created attachment 155261 [details] [review]
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the style of the
OIA sets administration screen, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The patch also corrects the structure of the form on the OAI set
mappings page so that the submit button is outside the "page-section"
area.

To test, apply the patch and go to Administration -> OAI sets. Test each
variation of the page:

- Main page
- New OAI set
- Edit OAI set
- OAI set mappings
Comment 4 Emily-Rose Francoeur 2023-09-11 14:14:57 UTC
Created attachment 155495 [details] [review]
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the style of the
OIA sets administration screen, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The patch also corrects the structure of the form on the OAI set
mappings page so that the submit button is outside the "page-section"
area.

To test, apply the patch and go to Administration -> OAI sets. Test each
variation of the page:

- Main page
- New OAI set
- Edit OAI set
- OAI set mappings

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 5 Katrin Fischer 2023-09-17 13:25:22 UTC
Created attachment 155755 [details] [review]
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the style of the
OIA sets administration screen, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The patch also corrects the structure of the form on the OAI set
mappings page so that the submit button is outside the "page-section"
area.

To test, apply the patch and go to Administration -> OAI sets. Test each
variation of the page:

- Main page
- New OAI set
- Edit OAI set
- OAI set mappings

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-09-18 15:03:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-09-18 20:36:19 UTC
Like others, not pushed to 23.05.x