Bug 34402 - Sorting holds on patron account includes articles
Summary: Sorting holds on patron account includes articles
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 33528
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-25 20:07 UTC by Kristi
Modified: 2023-09-15 10:13 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04


Attachments
SortHoldsScreenShot (31.96 KB, image/png)
2023-07-25 20:07 UTC, Kristi
Details
Bug 34402: Sorting holds on patron account includes articles (2.27 KB, patch)
2023-07-26 12:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34402: Sorting holds on patron account includes articles (2.31 KB, patch)
2023-08-01 14:42 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34402: Sorting holds on patron account includes articles (2.37 KB, patch)
2023-08-01 20:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kristi 2023-07-25 20:07:44 UTC
Created attachment 153892 [details]
SortHoldsScreenShot

When sorting checkouts by title on a patron's account, articles are ignored. When sorting holds by title, articles are included. 

It would be great if the holds tab of a patron's account also ignored articles (a, an, the) when sorting by title.
Comment 1 Owen Leonard 2023-07-26 12:33:30 UTC
Created attachment 153923 [details] [review]
Bug 34402: Sorting holds on patron account includes articles

This patch adds some configuration to the table of holds shown on the
checkout and patron detail pages so that sorting by title correctly
excludes articles.

To test, apply the patch and clear your browser cache.

- Check out to a patron who has multiple holds on titles which include
  leading articles like "a" "an" and "the."
- Click the holds tab and click the "title" column to sort by title.
  - The titles should be correctly sorted alphabetically while ignoring
    articles.
Comment 2 Sam Lau 2023-08-01 14:42:42 UTC
Created attachment 154129 [details] [review]
Bug 34402: Sorting holds on patron account includes articles

This patch adds some configuration to the table of holds shown on the
checkout and patron detail pages so that sorting by title correctly
excludes articles.

To test, apply the patch and clear your browser cache.

- Check out to a patron who has multiple holds on titles which include
  leading articles like "a" "an" and "the."
- Click the holds tab and click the "title" column to sort by title.
  - The titles should be correctly sorted alphabetically while ignoring
    articles.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-08-01 20:47:57 UTC
Created attachment 154135 [details] [review]
Bug 34402: Sorting holds on patron account includes articles

This patch adds some configuration to the table of holds shown on the
checkout and patron detail pages so that sorting by title correctly
excludes articles.

To test, apply the patch and clear your browser cache.

- Check out to a patron who has multiple holds on titles which include
  leading articles like "a" "an" and "the."
- Click the holds tab and click the "title" column to sort by title.
  - The titles should be correctly sorted alphabetically while ignoring
    articles.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-09-12 12:43:35 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-14 18:05:02 UTC
Bug description describes the problem.
But the commit message should describe the solution, ie :
"Exclude articles from title when sorting holds on patron account"
Comment 6 Fridolin Somers 2023-09-14 18:05:32 UTC
Pushed to 23.05.x for 23.05.04
Comment 7 Matt Blenkinsop 2023-09-15 10:13:07 UTC
patron-detail-tabs.inc does not exist in 22.11.x as bug 33528 was not backported - unable to backport to 22.11.x