Bug 34403 - Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header
Summary: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, an...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 20:08 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:21 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header (4.96 KB, patch)
2023-09-05 16:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header (5.01 KB, patch)
2023-09-06 02:28 UTC, David Cook
Details | Diff | Splinter Review
Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header (5.07 KB, patch)
2023-09-08 09:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 20:08:56 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Currencies and exchange rates page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Remove last level. There is no option to change only the exchange rates, so there is no need to specify we are in Currencies > Currencies and exchange rates.

Breadcrumb
- In the deletion confirmation page, the currency code is bold, change to regular weight and add single quotes

Page header
- The styling of the header of the 'New currency' page is different from the rest
- The styling of the header of the 'Modify currency' page is different from the rest
- Add the currency code, in single quotes, in the Modify header ('Modify currency' -> "Modify currency 'ISO'")
- In the deletion confirmation page, add single quote around the currency code
Comment 1 Owen Leonard 2023-09-05 16:50:35 UTC
Created attachment 155228 [details] [review]
Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header

This patch updates the currencies administration page in order to make
the page title, breadcrumb navigation, and page headings consistent with
each other.

To test, apply the patch and go to Administration -> Currencies and
exchange rates. Test each variation of the page to confirm that the
title, breadcrumbs, and headings are consistent.

- Currencies main page
- New currency
- Edit currency
- Delete currency confirmation
Comment 2 David Cook 2023-09-06 02:28:22 UTC
Created attachment 155249 [details] [review]
Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header

This patch updates the currencies administration page in order to make
the page title, breadcrumb navigation, and page headings consistent with
each other.

To test, apply the patch and go to Administration -> Currencies and
exchange rates. Test each variation of the page to confirm that the
title, breadcrumbs, and headings are consistent.

- Currencies main page
- New currency
- Edit currency
- Delete currency confirmation

Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 3 Katrin Fischer 2023-09-08 09:46:45 UTC
Created attachment 155387 [details] [review]
Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header

This patch updates the currencies administration page in order to make
the page title, breadcrumb navigation, and page headings consistent with
each other.

To test, apply the patch and go to Administration -> Currencies and
exchange rates. Test each variation of the page to confirm that the
title, breadcrumbs, and headings are consistent.

- Currencies main page
- New currency
- Edit currency
- Delete currency confirmation

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi 2023-09-08 14:54:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-08 19:57:41 UTC
Like others, not backported to 23.05.x