Bug 34405 - Inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and header
Summary: Inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 20:56 UTC by Caroline Cyr La Rose
Modified: 2023-10-25 06:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34405: Fix inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and headers (7.59 KB, patch)
2023-10-06 11:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34405: Fix inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and headers (7.66 KB, patch)
2023-10-17 13:00 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 20:56:27 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the EDI accounts and library EAN page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Add new account' to 'New account'
- Add account ID (?), in single quotes, to Modify account? I'm not sure what makes sense here.
- Add account ID (?), in single quotes, to Confirm deletion of account? I'm not sure what makes sense here.
- Change 'Add new library EAN' to 'New library EAN'
- Add EAN in single quotes to Modify library EAN
- Add EAN in single quotes to Confirm deletion of EAN
- Change EAN to library EAN in Confirm deletion of


Breadcrumb
- Change 'Add new account' to 'New account'
- Add account ID (?) to Modify account? I'm not sure what makes sense here.
- Add account ID (?) to Confirm deletion of account? I'm not sure what makes sense here.
- Change 'Add new library EAN' to 'New library EAN'
- Add EAN in single quotes to Modify library EAN
- Add EAN in single quotes to Confirm deletion of EAN
- Change EAN to library EAN in Confirm deletion of


Page header
- Styling of header for New account is different than usual
- Styling of header for Modify account is different than usual
- Add account ID (?) to Modify account? I'm not sure what makes sense here.
- Add account ID (?) to Confirm deletion of account? I'm not sure what makes sense here.
- Styling of header when adding a library EAN is different than usual
- Add EAN in single quotes to Modify library EAN
- Styling of header when modifying a library EAN is different than usual
- Change 'Delete EAN code for branchname?' to 'Confirm deletion of library EAN code for branchname'
- Add a condition so that 'for branchname' only appears if the EAN is for a specific library. Right now, an EAN for all libraries displays 'Delete EAN code for ?'
Comment 1 Owen Leonard 2023-10-06 11:39:41 UTC
Created attachment 156612 [details] [review]
Bug 34405: Fix inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in templates for EDI accounts
and Library EANs, making sure the page title, breadcrumb navigation, and
page headers are consistent with each other.

To test, apply the patch and check these views:

- Administration -> EDI accounts
  - New EDI account
  - Edit EDI account
  - Confirm deletion of EDI account
- Administration -> Library EANs
  - New library EAN
  - Edit library EAN
  - Confirm deletion of EDI account
    - With an account for a specific library
    - With an account for any library
Comment 2 Martin Renvoize 2023-10-17 13:00:08 UTC
Created attachment 157246 [details] [review]
Bug 34405: Fix inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in templates for EDI accounts
and Library EANs, making sure the page title, breadcrumb navigation, and
page headers are consistent with each other.

To test, apply the patch and check these views:

- Administration -> EDI accounts
  - New EDI account
  - Edit EDI account
  - Confirm deletion of EDI account
- Administration -> Library EANs
  - New library EAN
  - Edit library EAN
  - Confirm deletion of EDI account
    - With an account for a specific library
    - With an account for any library

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2023-10-17 13:00:32 UTC
Great consistency improvement.

No regressions, simple good fix

Passing QA
Comment 4 Tomás Cohen Arazi 2023-10-17 17:48:07 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-25 06:22:24 UTC
Not pushed to 23.05.x