Bug 34407 - Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header
Summary: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 21:23 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:21 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header (7.87 KB, patch)
2023-09-07 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header (8.03 KB, patch)
2023-09-11 13:57 UTC, Emily-Rose Francoeur
Details | Diff | Splinter Review
Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header (8.09 KB, patch)
2023-09-17 12:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 21:23:11 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Z39.50 servers page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add server code in single quotes to Modify Z39.50 server
- Add server code in single quotes to Modify SRU server


Breadcrumb
- Add single quotes around server code in Modify Z39.50 server
- Add single quotes around server code in Modify SRU server


Page header
- Remove 'administration' (change 'Z39.50/SRU servers administration' to 'Z39.50/SRU servers')
- Add server code in single quotes to Modify Z39.50 server
- Add server code in single quotes to Modify SRU server


No special page when deleting a server, simply a browser prompt.
Comment 1 Caroline Cyr La Rose 2023-07-25 21:56:21 UTC
While reviewing the pages modified by 33909, I noticed I hadn't specifically checked sru_modmapping.tt and sru_modmapping_auth.tt

Page title
- Administration level missing

Page header
- Page headers don't usually start with verbs. Maybe change to 'SRU search fields mapping for {type} records' and add a sentence underneath to specify this form is used to modify the mappings? I'm not married to that... I'm only mentioning it.
Comment 2 Owen Leonard 2023-09-07 17:36:18 UTC
Created attachment 155339 [details] [review]
Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header

This patch makes changes to the Z39.50 servers administration and
related templates in order to make them more consistent with other pages
in Koha.

One case has been added to page title and breadcrumb navigation: An
indication that a search has been performed. The subheading is modified
to make it clear that the search is a "starts with" search.

To test, apply the patch and go to Administration -> Z39.50/SRU
servers. View each variation of the page to confirm that breadcrumb
navigation, page title, and page headings are consistent with each
other.

- Z39.50/SRU servers list.
  - New Z39.50 server
  - New SRU server
  - Edit Z39.50 server
  - Edit SRU server
    - Modify SRU search field mapping for a bibliographic record
      server
    - Modify SRU search field mapping for an authority record server
  - Use the header search form to search for a server by name
Comment 3 Emily-Rose Francoeur 2023-09-11 13:57:09 UTC
Created attachment 155494 [details] [review]
Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header

This patch makes changes to the Z39.50 servers administration and
related templates in order to make them more consistent with other pages
in Koha.

One case has been added to page title and breadcrumb navigation: An
indication that a search has been performed. The subheading is modified
to make it clear that the search is a "starts with" search.

To test, apply the patch and go to Administration -> Z39.50/SRU
servers. View each variation of the page to confirm that breadcrumb
navigation, page title, and page headings are consistent with each
other.

- Z39.50/SRU servers list.
  - New Z39.50 server
  - New SRU server
  - Edit Z39.50 server
  - Edit SRU server
    - Modify SRU search field mapping for a bibliographic record
      server
    - Modify SRU search field mapping for an authority record server
  - Use the header search form to search for a server by name

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 4 Katrin Fischer 2023-09-17 12:55:27 UTC
Created attachment 155743 [details] [review]
Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header

This patch makes changes to the Z39.50 servers administration and
related templates in order to make them more consistent with other pages
in Koha.

One case has been added to page title and breadcrumb navigation: An
indication that a search has been performed. The subheading is modified
to make it clear that the search is a "starts with" search.

To test, apply the patch and go to Administration -> Z39.50/SRU
servers. View each variation of the page to confirm that breadcrumb
navigation, page title, and page headings are consistent with each
other.

- Z39.50/SRU servers list.
  - New Z39.50 server
  - New SRU server
  - Edit Z39.50 server
  - Edit SRU server
    - Modify SRU search field mapping for a bibliographic record
      server
    - Modify SRU search field mapping for an authority record server
  - Use the header search form to search for a server by name

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-09-18 15:04:02 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-18 20:08:03 UTC
Like others, not pushed to 23.05.x