Bug 34408 - Inconsistencies in SMTP servers page titles, breadcrumbs, and header
Summary: Inconsistencies in SMTP servers page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 33909 34616
Blocks: 34396 34619
  Show dependency treegraph
 
Reported: 2023-07-25 21:27 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:21 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header (4.01 KB, patch)
2023-08-25 16:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header (3.83 KB, patch)
2023-08-25 18:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header (3.89 KB, patch)
2023-08-28 09:11 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header (3.98 KB, patch)
2023-09-01 09:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 21:27:52 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the SMTP servers page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Edit SMTP server' to "Modify SMTP server 'name'"

Breadcrumb
- Change 'New' to 'New SMTP server'
- Change 'Edit' to "Modify SMTP server 'name'"


Page header
- Change 'Edit SMTP server' to "Modify SMTP server 'name'"

No special page to confirm deletion of server, only a modal.
Comment 1 Owen Leonard 2023-08-25 16:08:07 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-08-25 18:36:18 UTC
Created attachment 154847 [details] [review]
Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header

This patch updates the SMTP servers administration page in order to make
the page title, breadcrumb navigation, and page headings consistent with
each other.

The patch also adds a space between the delete button icon and the text.

To test apply the patch and go to Administration -> SMTP servers.

- Confirm that the page header, breadcrumb navigation, and page headings
  are consistent on each view of the page:
  - Main page
  - New SMTP server
  - Edit SMTP server
Comment 3 Pedro Amorim 2023-08-28 09:11:39 UTC
Created attachment 154875 [details] [review]
Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header

This patch updates the SMTP servers administration page in order to make
the page title, breadcrumb navigation, and page headings consistent with
each other.

The patch also adds a space between the delete button icon and the text.

To test apply the patch and go to Administration -> SMTP servers.

- Confirm that the page header, breadcrumb navigation, and page headings
  are consistent on each view of the page:
  - Main page
  - New SMTP server
  - Edit SMTP server

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Marcel de Rooy 2023-09-01 09:41:39 UTC
Created attachment 155087 [details] [review]
Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header

This patch updates the SMTP servers administration page in order to make
the page title, breadcrumb navigation, and page headings consistent with
each other.

The patch also adds a space between the delete button icon and the text.

To test apply the patch and go to Administration -> SMTP servers.

- Confirm that the page header, breadcrumb navigation, and page headings
  are consistent on each view of the page:
  - Main page
  - New SMTP server
  - Edit SMTP server

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-09-01 14:10:40 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 00:33:15 UTC
Depends on Bug 33909 not in 23.05.x