While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the SMTP servers page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Edit SMTP server' to "Modify SMTP server 'name'" Breadcrumb - Change 'New' to 'New SMTP server' - Change 'Edit' to "Modify SMTP server 'name'" Page header - Change 'Edit SMTP server' to "Modify SMTP server 'name'" No special page to confirm deletion of server, only a modal.
Created attachment 154836 [details] [review] Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header This patch updates the SMTP servers administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. The patch also adds a space between the delete button icon and the text. To test apply the patch and go to Administration -> SMTP servers. - Confirm that the page header, breadcrumb navigation, and page headings are consistent on each view of the page: - Main page - New SMTP server - Edit SMTP server
Created attachment 154847 [details] [review] Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header This patch updates the SMTP servers administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. The patch also adds a space between the delete button icon and the text. To test apply the patch and go to Administration -> SMTP servers. - Confirm that the page header, breadcrumb navigation, and page headings are consistent on each view of the page: - Main page - New SMTP server - Edit SMTP server
Created attachment 154875 [details] [review] Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header This patch updates the SMTP servers administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. The patch also adds a space between the delete button icon and the text. To test apply the patch and go to Administration -> SMTP servers. - Confirm that the page header, breadcrumb navigation, and page headings are consistent on each view of the page: - Main page - New SMTP server - Edit SMTP server Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 155087 [details] [review] Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header This patch updates the SMTP servers administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. The patch also adds a space between the delete button icon and the text. To test apply the patch and go to Administration -> SMTP servers. - Confirm that the page header, breadcrumb navigation, and page headings are consistent on each view of the page: - Main page - New SMTP server - Edit SMTP server Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 33909 not in 23.05.x