Bug 34411 - Inconsistencies in Additional fields page titles, breadcrumbs, and header
Summary: Inconsistencies in Additional fields page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 21:42 UTC by Caroline Cyr La Rose
Modified: 2023-09-19 12:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header (6.20 KB, patch)
2023-09-07 15:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header (6.25 KB, patch)
2023-09-11 13:40 UTC, Salah Ghedda
Details | Diff | Splinter Review
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header (6.25 KB, patch)
2023-09-11 13:41 UTC, Salah Ghedda
Details | Diff | Splinter Review
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header (6.31 KB, patch)
2023-09-17 13:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 21:42:11 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Additional fields page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Manage additional fields' to 'Additional fields'
- Add level by table (like breadcrumbs)
- Change 'Add additional field' to "New additional field for 'table'"

Breadcrumb
- Change 'Manage additional fields' to 'Additional fields'
- Change "Modify fields for 'table'" to "Additional fields for 'table'"
- Change 'Add field' to "New additional field for 'table'"
- Change "Modify field 'name'" to "Modify additional field 'name'"

Page header
- Change 'Add field' to "New additional field for 'table'"
- Change 'Modify field' to "Modify additional field 'name'"


Change 'Create field' button to 'New field'.

No special page to confirm deletion, only a browser prompt.
Comment 1 Owen Leonard 2023-09-07 15:08:00 UTC
Created attachment 155319 [details] [review]
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header

This patch makes changes to the additional fields administration
template in order to make it more consistent with other pages in Koha.

To test, apply the patch and go to Administration -> Additional fields.
View each variation of the page to confirm that breadcrumb navigation,
page title, and page headings are consistent with each other.

- Main list
  - Table view (e.g. aqbasket, aqorders, etc)
    - New field
    - Edit field
Comment 2 Salah Ghedda 2023-09-11 13:40:21 UTC
Created attachment 155491 [details] [review]
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header

This patch makes changes to the additional fields administration
template in order to make it more consistent with other pages in Koha.

To test, apply the patch and go to Administration -> Additional fields.
View each variation of the page to confirm that breadcrumb navigation,
page title, and page headings are consistent with each other.

- Main list
  - Table view (e.g. aqbasket, aqorders, etc)
    - New field
    - Edit field

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Comment 3 Salah Ghedda 2023-09-11 13:41:21 UTC
Created attachment 155492 [details] [review]
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header

This patch makes changes to the additional fields administration
template in order to make it more consistent with other pages in Koha.

To test, apply the patch and go to Administration -> Additional fields.
View each variation of the page to confirm that breadcrumb navigation,
page title, and page headings are consistent with each other.

- Main list
  - Table view (e.g. aqbasket, aqorders, etc)
    - New field
    - Edit field

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>


Signed Off
Comment 4 Katrin Fischer 2023-09-17 13:04:51 UTC
Created attachment 155745 [details] [review]
Bug 34411: Inconsistencies in Additional fields page titles, breadcrumbs, and header

This patch makes changes to the additional fields administration
template in order to make it more consistent with other pages in Koha.

To test, apply the patch and go to Administration -> Additional fields.
View each variation of the page to confirm that breadcrumb navigation,
page title, and page headings are consistent with each other.

- Main list
  - Table view (e.g. aqbasket, aqorders, etc)
    - New field
    - Edit field

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-09-18 15:04:10 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-18 20:08:59 UTC
Like others, not pushed to 23.05.x