Bug 34422 - Reindent facets.inc
Summary: Reindent facets.inc
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-26 16:35 UTC by Owen Leonard
Modified: 2023-10-26 06:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34422: Reindent factets.inc (13.40 KB, patch)
2023-07-26 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34422: (follow-up) Add markup comments (3.44 KB, patch)
2023-07-26 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34422: (follow-up) Add markup comments (3.52 KB, patch)
2023-07-31 08:44 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34422: Reindent factets.inc (13.48 KB, patch)
2023-07-31 08:45 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34422: (follow-up) Add markup comments (3.52 KB, patch)
2023-07-31 08:45 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34422: Reindent factets.inc (13.46 KB, patch)
2023-08-22 15:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34422: (follow-up) Add markup comments (3.50 KB, patch)
2023-08-22 15:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34422: Reindent factets.inc (14.25 KB, patch)
2023-10-17 16:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34422: (follow-up) Add markup comments (3.97 KB, patch)
2023-10-17 16:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34422: Reindent factets.inc (14.31 KB, patch)
2023-10-20 20:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34422: (follow-up) Add markup comments (4.02 KB, patch)
2023-10-20 20:20 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-26 16:35:12 UTC
I would like to reformat the staff interface search facets include so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2023-07-26 16:48:28 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-07-26 16:48:30 UTC Comment hidden (obsolete)
Comment 3 Matt Blenkinsop 2023-07-31 08:44:22 UTC Comment hidden (obsolete)
Comment 4 Matt Blenkinsop 2023-07-31 08:45:01 UTC Comment hidden (obsolete)
Comment 5 Matt Blenkinsop 2023-07-31 08:45:03 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2023-08-22 15:09:48 UTC
Created attachment 154700 [details] [review]
Bug 34422: Reindent factets.inc

This patch reindents the staff interface catalog search results facets
template so that it has consistent indentation. These changes should
have no visible effect on the page.

To test, apply the patch and perform a catalog search in the staff
interface.The facets should look the same as always.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 7 Owen Leonard 2023-08-22 15:09:50 UTC
Created attachment 154701 [details] [review]
Bug 34422: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 8 Katrin Fischer 2023-09-21 20:54:16 UTC
Can you please rebase?
Comment 9 Owen Leonard 2023-10-17 16:57:49 UTC
Created attachment 157272 [details] [review]
Bug 34422: Reindent factets.inc

This patch reindents the staff interface catalog search results facets
template so that it has consistent indentation. These changes should
have no visible effect on the page.

To test, apply the patch and perform a catalog search in the staff
interface.The facets should look the same as always.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 10 Owen Leonard 2023-10-17 16:57:51 UTC
Created attachment 157273 [details] [review]
Bug 34422: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 11 Katrin Fischer 2023-10-20 20:20:25 UTC
Created attachment 157572 [details] [review]
Bug 34422: Reindent factets.inc

This patch reindents the staff interface catalog search results facets
template so that it has consistent indentation. These changes should
have no visible effect on the page.

To test, apply the patch and perform a catalog search in the staff
interface.The facets should look the same as always.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2023-10-20 20:20:29 UTC
Created attachment 157573 [details] [review]
Bug 34422: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Tomás Cohen Arazi 2023-10-20 20:36:51 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Fridolin Somers 2023-10-26 06:28:57 UTC
Enhancement not pushed to 23.05.x