Bug 34436 - Some breadcrumbs lack <span> for translatability
Summary: Some breadcrumbs lack <span> for translatability
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-27 16:09 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10
Circulation function:


Attachments
Bug 34436: Some breadcrumbs lack <span> for translatability (8.67 KB, patch)
2023-07-27 16:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34436: Some breadcrumbs lack <span> for translatability (8.72 KB, patch)
2023-08-01 14:35 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34436: Some breadcrumbs lack <span> for translatability (8.77 KB, patch)
2023-08-01 20:44 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34436: (QA follow-up) Move spans to surround full text (1.99 KB, patch)
2023-08-01 20:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-27 16:09:53 UTC
In my update of breadcrumbs to use a template wrapper I missed a few instances where a string needs to be wrapped in <span> in order to be picked up by the translation tool.
Comment 1 Owen Leonard 2023-07-27 16:28:44 UTC
Created attachment 153996 [details] [review]
Bug 34436: Some breadcrumbs lack <span> for translatability

This patch modifies several templates which were updated recently so
that breadcrumbs markup could be built using template wrappers. The
patch wraps strings in <span> in cases where it is necessary to make
them translatable.

To test, apply the patch and view the following pages to confirm that
the breadcrumbs still show up correctly:

- Administration -> MARC bibliographic framework
  - Add framework
  - Edit framework
  - Delete framework
- Administration -> Share content with Mana KB
- Administration -> Circulation and fine rules
- Authorities ->
  - Add authority
  - Edit authority
- Catalog -> Advanced search
  - Bibliographic detail page
    - Must have EasyAnalyticalRecords enabled.
    - Edit -> Link to host record
- Patrons
- Reports -> Average loan time
- Serials -> Serials home
Comment 2 Sam Lau 2023-08-01 14:35:47 UTC
Created attachment 154128 [details] [review]
Bug 34436: Some breadcrumbs lack <span> for translatability

This patch modifies several templates which were updated recently so
that breadcrumbs markup could be built using template wrappers. The
patch wraps strings in <span> in cases where it is necessary to make
them translatable.

To test, apply the patch and view the following pages to confirm that
the breadcrumbs still show up correctly:

- Administration -> MARC bibliographic framework
  - Add framework
  - Edit framework
  - Delete framework
- Administration -> Share content with Mana KB
- Administration -> Circulation and fine rules
- Authorities ->
  - Add authority
  - Edit authority
- Catalog -> Advanced search
  - Bibliographic detail page
    - Must have EasyAnalyticalRecords enabled.
    - Edit -> Link to host record
- Patrons
- Reports -> Average loan time
- Serials -> Serials home

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-08-01 20:44:38 UTC
Created attachment 154133 [details] [review]
Bug 34436: Some breadcrumbs lack <span> for translatability

This patch modifies several templates which were updated recently so
that breadcrumbs markup could be built using template wrappers. The
patch wraps strings in <span> in cases where it is necessary to make
them translatable.

To test, apply the patch and view the following pages to confirm that
the breadcrumbs still show up correctly:

- Administration -> MARC bibliographic framework
  - Add framework
  - Edit framework
  - Delete framework
- Administration -> Share content with Mana KB
- Administration -> Circulation and fine rules
- Authorities ->
  - Add authority
  - Edit authority
- Catalog -> Advanced search
  - Bibliographic detail page
    - Must have EasyAnalyticalRecords enabled.
    - Edit -> Link to host record
- Patrons
- Reports -> Average loan time
- Serials -> Serials home

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-08-01 20:44:41 UTC
Created attachment 154134 [details] [review]
Bug 34436: (QA follow-up) Move spans to surround full text

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-08-01 20:45:13 UTC
-                Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])?
+                <span>Delete framework for [% framework.frameworktext | html %]</span> ([% framework.frameworkcode | html %])?

The span should be after the ? because you might have a different sentence structure for a question.
Comment 6 Tomás Cohen Arazi (tcohen) 2023-08-15 08:25:00 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-08-29 21:35:32 UTC
Pushed to 23.05.x for 23.05.04
Comment 8 Matt Blenkinsop 2023-08-31 09:47:55 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x