When printing a quick spine label, the background of the pop-up window is still in the old style. To recreate: 0. Make sure to have an item with a call number and a barcode 1. Go to Cataloging > Quick spine label creator 2. Enter the barcode of the item and press Enter --> The background of the pop-up is blue
Created attachment 154277 [details] [review] Bug 34453: Update background of quick spine label pop-up This patch updates the quick spine label popup so that the footer uses the same markup as the recently updated Z39.50 popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. Go to Cataloging -> Quick spine label creator. - Test the form with both an existing barcode and a non-existent barcode. - In the pop-up window, confirm that the footer looks correct and that the buttons in the footer, in both cases, work correctly.
Created attachment 154282 [details] [review] Bug 34453: Update background of quick spine label pop-up This patch updates the quick spine label popup so that the footer uses the same markup as the recently updated Z39.50 popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. Go to Cataloging -> Quick spine label creator. - Test the form with both an existing barcode and a non-existent barcode. - In the pop-up window, confirm that the footer looks correct and that the buttons in the footer, in both cases, work correctly. Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 154306 [details] [review] Bug 34453: Update background of quick spine label pop-up This patch updates the quick spine label popup so that the footer uses the same markup as the recently updated Z39.50 popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. Go to Cataloging -> Quick spine label creator. - Test the form with both an existing barcode and a non-existent barcode. - In the pop-up window, confirm that the footer looks correct and that the buttons in the footer, in both cases, work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Owen!
Created attachment 156010 [details] [review] Bug 34453: Update background of quick spine label pop-up This patch updates the quick spine label popup so that the footer uses the same markup as the recently updated Z39.50 popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. Go to Cataloging -> Quick spine label creator. - Test the form with both an existing barcode and a non-existent barcode. - In the pop-up window, confirm that the footer looks correct and that the buttons in the footer, in both cases, work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x