Bug 34453 - Update background of quick spine label pop-up
Summary: Update background of quick spine label pop-up
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 34343
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-01 20:28 UTC by Caroline Cyr La Rose
Modified: 2023-09-25 12:29 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34453: Update background of quick spine label pop-up (3.04 KB, patch)
2023-08-04 13:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34453: Update background of quick spine label pop-up (3.09 KB, patch)
2023-08-04 14:41 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34453: Update background of quick spine label pop-up (3.16 KB, patch)
2023-08-07 14:18 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34453: Update background of quick spine label pop-up (3.21 KB, patch)
2023-09-21 20:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-08-01 20:28:00 UTC
When printing a quick spine label, the background of the pop-up window is still in the old style.

To recreate:
0. Make sure to have an item with a call number and a barcode
1. Go to Cataloging > Quick spine label creator
2. Enter the barcode of the item and press Enter
   --> The background of the pop-up is blue
Comment 1 Owen Leonard 2023-08-04 13:37:34 UTC
Created attachment 154277 [details] [review]
Bug 34453: Update background of quick spine label pop-up

This patch updates the quick spine label popup so that the footer uses
the same markup as the recently updated Z39.50 popup window in
cataloging.

To test, apply the patch and rebuild the staff interface CSS.

Go to Cataloging -> Quick spine label creator.

 - Test the form with both an existing barcode and a non-existent
   barcode.
   - In the pop-up window, confirm that the footer looks correct and
     that the buttons in the footer, in both cases, work correctly.
Comment 2 Sam Lau 2023-08-04 14:41:15 UTC Comment hidden (obsolete)
Comment 3 Caroline Cyr La Rose 2023-08-07 14:18:21 UTC
Created attachment 154306 [details] [review]
Bug 34453: Update background of quick spine label pop-up

This patch updates the quick spine label popup so that the footer uses
the same markup as the recently updated Z39.50 popup window in
cataloging.

To test, apply the patch and rebuild the staff interface CSS.

Go to Cataloging -> Quick spine label creator.

 - Test the form with both an existing barcode and a non-existent
   barcode.
   - In the pop-up window, confirm that the footer looks correct and
     that the buttons in the footer, in both cases, work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Caroline Cyr La Rose 2023-08-07 14:20:23 UTC
Thanks Owen!
Comment 5 Katrin Fischer 2023-09-21 20:48:46 UTC
Created attachment 156010 [details] [review]
Bug 34453: Update background of quick spine label pop-up

This patch updates the quick spine label popup so that the footer uses
the same markup as the recently updated Z39.50 popup window in
cataloging.

To test, apply the patch and rebuild the staff interface CSS.

Go to Cataloging -> Quick spine label creator.

 - Test the form with both an existing barcode and a non-existent
   barcode.
   - In the pop-up window, confirm that the footer looks correct and
     that the buttons in the footer, in both cases, work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-09-22 14:35:06 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-09-22 19:52:47 UTC
Enhancement not pushed to 23.05.x