Adding the patron's cardnumber to the Hold details page can help libraries verify whether they are placing the hold for the correct patron. Especially if they have several patrons with the same or similar name. /cgi-bin/koha/reserve/request.pl
Created attachment 154157 [details] [review] Bug 34457: Added the patron's cardnumber to the hold details page Test plan: 1. Go to place a hold on a patron 2. The hold details page (/cgi-bin/koha/reserve/request.pl) only shows the patron’s name. 3. Apply the patch 4. The hold details page now shows the patron’s name and their card number. 5. Sign off!
Created attachment 154161 [details] [review] Bug 34457: Added the patron's cardnumber to the hold details page Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Really nice idea for a patch - works as expected, signed off.
Created attachment 154162 [details] [review] Bug 34457: Added the patron's cardnumber to the hold details page Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Christine Lee <chlee@pascolibraries.org>
There's no need to remove the use of the patron-title include file. You can remove the "no_cardnumber => 1" from that line and it will work just how you want it to.
Created attachment 154234 [details] [review] Bug 34457: Rebased added the patron's cardnumber to the hold details page Same test plan as before
(In reply to Owen Leonard from comment #5) > There's no need to remove the use of the patron-title include file. > > You can remove the "no_cardnumber => 1" from that line and it will work just > how you want it to. Thank you, Owen.
Created attachment 154295 [details] [review] Bug 34457: Added cardnumber view to hold details page Test plan: 1. Go to place a hold on a patron 2. The hold details page (/cgi-bin/koha/reserve/request.pl) only shows the patron’s name. 3. Apply the patch 4. The hold details page now shows the patron’s name and their card number. 5. Sign off!
Created attachment 154387 [details] [review] Bug 34457: Added cardnumber view to hold details page Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Works as described!
Created attachment 156691 [details] [review] Bug 34457: Added cardnumber view to hold details page Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :) (tested with a long name and long card number, page layout is still good) @Laura it seem the test plan was put in the bugzilla comment when attaching the commit. It works better to put it in the commit message directly. That way a signoff doesn't cause the test plan to be lost.
Pushed to master for 23.11. Nice work everyone, thanks!
Very useful, I choose to backport. Pushed to 23.05.x for 23.05.05
Enhancement - not backporting to 22.11.x