Bug 34493 - Bad indenting in search_indexes.inc
Summary: Bad indenting in search_indexes.inc
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 32683
Blocks:
  Show dependency tree / graph
 
Reported: 2023-08-07 23:10 UTC by Fridolin Somers
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09
Circulation function:

Attachments
Bug 34493: Fix indenting in search_indexes.inc (9.53 KB, patch)
2023-08-07 23:13 UTC, Fridolin Somers 		Details | Diff | Splinter Review
Bug 34493: Fix indenting in search_indexes.inc (9.58 KB, patch)
2023-08-07 23:42 UTC, David Nind 		Details | Diff | Splinter Review
Bug 34493: Fix indenting in search_indexes.inc (9.64 KB, patch)
2023-08-13 00:05 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-08-07 23:10:45 UTC 
Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
Not on purpose looks like.
Comment 1 Fridolin Somers 2023-08-07 23:13:11 UTC 
Created attachment 154311 [details] [review]
Bug 34493: Fix indenting in search_indexes.inc

Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
Not on purpose looks like.

Test plan :
1) Look at changes to validate indenting
2) Run prove xt/tt_valid.t
Comment 2 David Nind 2023-08-07 23:42:39 UTC 
Created attachment 154312 [details] [review]
Bug 34493: Fix indenting in search_indexes.inc

Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
Not on purpose looks like.

Test plan :
1) Look at changes to validate indenting
2) Run prove xt/tt_valid.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-08-13 00:05:00 UTC 
Created attachment 154398 [details] [review]
Bug 34493: Fix indenting in search_indexes.inc

Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
Not on purpose looks like.

Test plan :
1) Look at changes to validate indenting
2) Run prove xt/tt_valid.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-08-13 00:06:26 UTC 
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Tomás Cohen Arazi (tcohen) 2023-08-15 09:14:40 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-08-17 19:50:22 UTC 
Pushed to 23.05.x for 23.05.03
Comment 7 Pedro Amorim 2023-08-18 13:51:52 UTC 
Nice work everyone!

Pushed to 22.11.x for next release