Bug 34501 - Patron purchase suggestion table should include the non-public note
Summary: Patron purchase suggestion table should include the non-public note
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Laura Escamilla
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-08 21:12 UTC by Laura Escamilla
Modified: 2023-11-30 13:45 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/750
Text to go in the release notes:
This adds a new column to the suggestions table for the non-public note.
Version(s) released in:
23.11.00


Attachments
Bug 34501: Added Non-public notes to the member purchase suggestion table (1.51 KB, patch)
2023-08-08 21:19 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 34501: Added Non-public notes to the member purchase suggestion table (1.58 KB, patch)
2023-08-11 15:47 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34501: Added Non-public notes to the member purchase suggestion table (1.67 KB, patch)
2023-09-29 09:56 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2023-08-08 21:12:46 UTC
Currently the purchase suggestion table at /cgi-bin/koha/members/purchase-suggestions.pl only shows the public note, but not the non-public note.
Comment 1 Laura Escamilla 2023-08-08 21:19:12 UTC
Created attachment 154323 [details] [review]
Bug 34501: Added Non-public notes to the member purchase suggestion table

To test: 
1. Create a new purchase suggestion for a patron and add a “Note” and a “Non-public Note”
2. View the purchase suggestion on the patron page at /cgi-bin/koha/members/purchase-suggestions.pl
    1. It currently only shows the public note
3. Apply this patch
4. Refresh the page, it now shows both the “Note” and “Non-public Note”
5. Sign off!
Comment 2 ByWater Sandboxes 2023-08-11 15:47:45 UTC
Created attachment 154378 [details] [review]
Bug 34501: Added Non-public notes to the member purchase suggestion table

Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>
Comment 3 Lisette Scheer 2023-08-11 15:48:40 UTC
Worked as expected!
Lisette
Comment 4 Marcel de Rooy 2023-09-29 09:56:33 UTC
Created attachment 156374 [details] [review]
Bug 34501: Added Non-public notes to the member purchase suggestion table

Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-10-20 14:48:36 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-26 06:07:05 UTC
No need to adapt column settings?
Comment 7 Katrin Fischer 2023-10-28 22:37:15 UTC
(In reply to Fridolin Somers from comment #6)
> No need to adapt column settings?

I checked: the acquisitions > suggestions have column configuration, but the table in the patron's account in the staff interface doesn't. So we are good.
Comment 8 Fridolin Somers 2023-11-03 08:32:08 UTC
OK great
Comment 9 Caroline Cyr La Rose 2023-11-10 15:00:05 UTC
Screenshot has been updated in the manual.